[squeak-dev] The Trunk: Tools-cmm.507.mcz

commits at source.squeak.org commits at source.squeak.org
Mon Dec 2 19:57:30 UTC 2013


Chris Muller uploaded a new version of Tools to project The Trunk:
http://source.squeak.org/trunk/Tools-cmm.507.mcz

==================== Summary ====================

Name: Tools-cmm.507
Author: cmm
Time: 2 December 2013, 1:56:35.213 pm
UUID: b97af8db-8cef-4648-bad5-3f6343ff95f2
Ancestors: Tools-fbs.506

- RecentMessageSet don't blow up if you get out-of-sync with RecentMessages default.
- Don't filter for #isValid in the UI.  Instead, maintain a valid domain.

=============== Diff against Tools-fbs.506 ===============

Item was changed:
  ----- Method: RecentMessageSet>>reformulateList (in category 'update') -----
  reformulateList
  	"Reformulate the receiver's list.  Exclude methods now deleted"
+ 	self
+ 		 initializeMessageList: RecentMessages default methodReferences ;
+ 		 messageListIndex: (messageList size min: 1) ;
+ 		 changed: #messageList ;
+ 		 changed: #messageListIndex!
- 	self initializeMessageList:
- 		(RecentMessages default methodReferences select:
- 			[ : each | each isValid ]).
- 	self messageListIndex: (messageList size min: 1). "0 or 1"
- 	self changed: #messageList.
- 	self changed: #messageListIndex!

Item was changed:
  ----- Method: RecentMessageSet>>updateListsAndCodeIn: (in category 'update') -----
+ updateListsAndCodeIn: aWindow 
- updateListsAndCodeIn: aWindow
- 
  	| recentFromUtilities |
+ 	self canDiscardEdits ifFalse: [ ^ self ].
- 	"RAA 20 june 2000 - a recent change to how messages were displayed in the list caused them not to match what was stored in Utilities. This caused the recent submissions to be continuously updated. The hack below fixed that problem"
- 
- 	self flag: #mref.	"in second pass, use simpler test"
- 
- 	self canDiscardEdits ifFalse: [^ self].
  	RecentMessages default isEmpty ifTrue: [ ^ self ].
+ 	recentFromUtilities := RecentMessages default mostRecent asString , ' '.
+ 	(messageList isEmpty or: [ messageList first asStringOrText asString beginsWith: recentFromUtilities ])
+ 		ifTrue: [ self updateCodePaneIfNeeded ]
+ 		ifFalse: [ self reformulateList ]!
- 	recentFromUtilities := RecentMessages default mostRecent asString,' '.
- 	(messageList first asStringOrText asString beginsWith: recentFromUtilities)
- 		ifFalse:
- 			[self reformulateList]
- 		ifTrue:
- 			[self updateCodePaneIfNeeded]!

Item was changed:
  ----- Method: Utilities class>>browseRecentSubmissions (in category '*Tools') -----
  browseRecentSubmissions
  	"Open up a browser on the most recent methods submitted in the image."
  	^ RecentMessageSet 
  		openMessageList: RecentMessages default methodReferences
+ 		name: 'Recent Submissions' 
- 		name: 'Recent submissions -- youngest first ' 
  		autoSelect: nil!

Item was changed:
  ----- Method: Utilities class>>recentSubmissionsWindow (in category '*Tools') -----
  recentSubmissionsWindow
  	"Answer a SystemWindow holding recent submissions"
+ 	| messageSet |
+ 	messageSet := RecentMessageSet messageList: RecentMessages default methodReferences.
- 
- 	| recentMessages messageSet |
- 	recentMessages := RecentMessages default methodReferences.
- 	messageSet := RecentMessageSet messageList: recentMessages.
  	messageSet autoSelectString: nil.
+ 	^ ToolBuilder build: messageSet!
- 	^ ToolBuilder build: messageSet
- 
- 	"Utilities recentSubmissionsWindow openInHand"
- 
- !



More information about the Squeak-dev mailing list