[squeak-dev] The Trunk: System-cmm.632.mcz

commits at source.squeak.org commits at source.squeak.org
Mon Dec 2 20:13:35 UTC 2013


Chris Muller uploaded a new version of System to project The Trunk:
http://source.squeak.org/trunk/System-cmm.632.mcz

==================== Summary ====================

Name: System-cmm.632
Author: cmm
Time: 2 December 2013, 2:12:28.796 pm
UUID: d70901de-91c8-4b3c-add9-998bf3cfac55
Ancestors: System-fbs.631

- Method to #resume RecentMessages, although I have no idea how it got stuck suspended.
- Only filter DoIt's from RecentMessages.
- Remove arbitrary restriction and inherit the Smalltalk environment's error-handling.

=============== Diff against System-fbs.631 ===============

Item was changed:
  ----- Method: RecentMessages class>>setRecentHistorySize (in category 'preferences') -----
  setRecentHistorySize
+ 	"Let the user specify the recent history size."
+ 	self numberOfRecentSubmissionsToStore:
+ 		(UIManager default
+ 			request: 'How many recent changes
+ should be remembered?'
+ 			initialAnswer: self numberOfRecentSubmissionsToStore asString)!
- 	"Let the user specify the recent history size"
- 
- 	| aReply aNumber |
- 	aReply := UIManager default request: 'How many recent methods
- should be maintained?' initialAnswer: self numberOfRecentSubmissionsToStore asString.
- 	aReply isEmptyOrNil ifFalse:
- 		[aNumber := aReply asNumber rounded.
- 		(aNumber > 1 and: [aNumber <= 1000])
- 			ifTrue:
- 				[self numberOfRecentSubmissionsToStore: aNumber.
- 				self inform: 'Okay, ', aNumber asString, ' is the new size of the recent method history']
- 			ifFalse:
- 				[self inform: 'Sorry, must be a number between 2 & 1000']]!

Item was changed:
  ----- Method: RecentMessages>>initialize (in category 'initialize-release') -----
  initialize
  	super initialize.
  	methodReferences := OrderedCollection new: (maximumSubmissionCount := 30).
+ 	self resume!
- 	isSuspended := false!

Item was changed:
  ----- Method: RecentMessages>>recordSelector:forClass:inEnvironment: (in category 'accessing') -----
  recordSelector: aSelector forClass: aClass inEnvironment: anEnvironment 
  	| ref |
  	(isSuspended = true or: [ aClass wantsChangeSetLogging not ]) ifTrue: [ ^ self ].
  	ref := MethodReference
  		class: aClass
  		selector: aSelector
  		environment: anEnvironment.
  	methodReferences
+ 		remove: ref
+ 		ifAbsent: [  ].
+ 	ref methodSymbol isDoIt ifFalse: [ methodReferences addFirst: ref ].
- 		remove: ref ifAbsent: [  ] ;
- 		addFirst: ref.
  	self trim!

Item was added:
+ ----- Method: RecentMessages>>resume (in category 'accessing') -----
+ resume
+ 	isSuspended := false!



More information about the Squeak-dev mailing list