[squeak-dev] The Trunk: System-fbs.641.mcz

Chris Muller ma.chris.m at gmail.com
Thu Dec 12 02:41:56 UTC 2013


It's in 4.4, but I've never seen it before today.

I smell an opportunity for addition-by-subtraction.

On Wed, Dec 11, 2013 at 6:47 PM, Nicolas Cellier
<nicolas.cellier.aka.nice at gmail.com> wrote:
> But there's nothing new there, is there?
>
>
> 2013/12/12 Chris Muller <asqueaker at gmail.com>
>>
>> This preference causes the image to interrupt the user with a modal
>> question upon starting!  Now _I'm_ starting to hyperventilate!
>>
>> All this code.  And String literals.  And more modal #inform:
>> interrupts.  (Shudder)  And right at the time when the user has
>> inertia enough toward a purpose, his reason to start the image, an
>> "intent" to do something else, is now interrupted by the stupid
>> software with a modal question.
>>
>> Not even MS Windows punishes its users this harshly.
>>
>> If you want to tell in image to update upon launch, pass in a command
>> argument to do that!
>>
>> Or, simply press Control+1, down, down, Enter.  3 extra keystrokes is
>> worth the freedom of staying in control, and ridding the image of this
>> embarassing scourge of a UI.
>>
>> I'm getting my buzzsaw...
>>
>> On Tue, Dec 10, 2013 at 3:45 PM,  <commits at source.squeak.org> wrote:
>> > Frank Shearar uploaded a new version of System to project The Trunk:
>> > http://source.squeak.org/trunk/System-fbs.641.mcz
>> >
>> > ==================== Summary ====================
>> >
>> > Name: System-fbs.641
>> > Author: fbs
>> > Time: 10 December 2013, 9:31:05.408 pm
>> > UUID: 7f3758d1-fed5-5443-a2af-6ce6461597ff
>> > Ancestors: System-fbs.640
>> >
>> > Make the #updateFromServerAtStartup preference a pragma preference.
>> > Update the old call sites. Remove the preference in the postscript.
>> >
>> > (Also, move #setSystemVersion to its more natural home. Extensions are
>> > great, but in this case we don't need one.)
>> >
>> > =============== Diff against System-fbs.640 ===============
>> >
>> > Item was changed:
>> >   ----- Method: AutoStart class>>processUpdates (in category 'updating')
>> > -----
>> >   processUpdates
>> >         "Process update files from a well-known update server.  This
>> > method is called at system startup time,   Only if the preference
>> > #updateFromServerAtStartup is true is the actual update processing
>> > undertaken automatically"
>> >         | choice |
>> > +       (MCMcmUpdater updateFromServerAtStartup) ifTrue:
>> > -       (Preferences valueOfFlag: #updateFromServerAtStartup) ifTrue:
>> >                 [choice := UIManager default chooseFrom: #('Yes, Update'
>> > 'No, Not now' 'Don''t ask again')
>> >                         title: 'Shall I look for new code\updates on the
>> > server?' withCRs.
>> >                 choice = 1 ifTrue: [
>> >                         MCMcmUpdater updateFromServer].
>> >                 choice = 3 ifTrue: [
>> > +                       MCMcmUpdater updateFromServerAtStartup: false.
>> > +                       self inform: 'Remember to save your image to
>> > make this setting permant.']].
>> > -                       Preferences setPreference:
>> > #updateFromServerAtStartup toValue: false.
>> > -                       self inform: 'Remember to save you image to make
>> > this setting permant.']].
>> >         ^false!
>> >
>> > Item was removed:
>> > - ----- Method: MCConfiguration>>setSystemVersion (in category
>> > '*System-Support-updating') -----
>> > - setSystemVersion
>> > -       "Set the current system version date to the latest date found in
>> > my configuration (or the associated working copy). Also set the highest
>> > update number to the sum of version numbers in my configuration."
>> > -
>> > -       | versionNumbers versionDates |
>> > -       versionNumbers := self dependencies collect: [:d |
>> > -               (d versionInfo name copyAfterLast: $.) asInteger].
>> > -       versionDates := self dependencies collect: [:d |
>> > -               d versionInfo date
>> > -                       ifNil: [d package workingCopy ancestors first
>> > date]].
>> > -       SystemVersion current
>> > -               date: versionDates max;
>> > -               highestUpdate: versionNumbers sum.!
>> >
>> > Item was removed:
>> > - ----- Method: MCMcmUpdater class>>updateFromServer (in category
>> > '*System-Support-updating') -----
>> > - updateFromServer
>> > -       "Update the image by loading all pending updates from the
>> > server."
>> > -       | config |
>> > -       "Flush all caches. If a previous download failed this is often
>> > helpful"
>> > -       MCFileBasedRepository flushAllCaches.
>> > -       config := MCMcmUpdater updateFromDefaultRepository.
>> > -       config ifNil: [^self inform: 'Unable to retrieve updates from
>> > remote repository.' translated].
>> > -       config setSystemVersion.
>> > -       self inform: ('Update completed.
>> > - Current update number: ' translated, SystemVersion current
>> > highestUpdate).!
>> >
>> > Item was added:
>> > + (PackageInfo named: 'System') postscript: 'MCMcmUpdater
>> > updateFromServerAtStartup: Preferences updateFromServerAtStartup.
>> > + Preferences removePreference: #updateFromServerAtStartup.'!
>> >
>> >
>>
>


More information about the Squeak-dev mailing list