[squeak-dev] The Trunk: 45Deprecated-nice.23.mcz

commits at source.squeak.org commits at source.squeak.org
Fri Dec 13 15:35:07 UTC 2013


Nicolas Cellier uploaded a new version of 45Deprecated to project The Trunk:
http://source.squeak.org/trunk/45Deprecated-nice.23.mcz

==================== Summary ====================

Name: 45Deprecated-nice.23
Author: nice
Time: 13 December 2013, 4:34:51.553 pm
UUID: b817f9c4-8cb8-4091-a337-8747717c6585
Ancestors: 45Deprecated-nice.22

Correct my fresh infinite loop in Parser>>initPattern:notifying:return:

=============== Diff against 45Deprecated-nice.22 ===============

Item was changed:
  ----- Method: Parser>>initPattern:notifying:return: (in category '*45Deprecated') -----
  initPattern: aString notifying: req return: aBlock
  
  	req
  		ifNil:
  			[self deprecated: 'Notifying nil is unnecessary, simply use #initPattern:return:'.
+ 			^self initPattern: aString return: aBlock]
- 			^self initPattern: aString notifying: req return: aBlock]
  		ifNotNil:
  			[| result |
  			self deprecated: '#initPattern:return: was preferred because everybody was notifying nil, but you.
  You could ask for re-integration of this message'.
  			self
  				init: (ReadStream on: aString asString)
  				cue: (CompilationCue source: aString requestor: req)
  				failBlock: [^nil].
  			encoder := self.
  			result := aBlock value: (self pattern: false inContext: nil).
  			encoder := failBlock := nil.  "break cycles"
  			^result]!



More information about the Squeak-dev mailing list