[squeak-dev] The Trunk: MorphicExtras-nice.137.mcz

commits at source.squeak.org commits at source.squeak.org
Fri Dec 13 21:08:45 UTC 2013


Nicolas Cellier uploaded a new version of MorphicExtras to project The Trunk:
http://source.squeak.org/trunk/MorphicExtras-nice.137.mcz

==================== Summary ====================

Name: MorphicExtras-nice.137
Author: nice
Time: 13 December 2013, 10:07:57.316 pm
UUID: 127ce68e-b210-42a3-b0b3-b40c69941d02
Ancestors: MorphicExtras-nice.136

Correct an awfull bug in PaintBoxMorph>>showColor
One should NEVER send pixelValueAt: nor colorAt: to an hibernated Form (or ColorForm).

=============== Diff against MorphicExtras-nice.136 ===============

Item was changed:
  ----- Method: PaintBoxMorph>>showColor (in category 'actions') -----
  showColor
  	"Display the current color in all brushes, both on and off."
  
  	| offIndex onIndex center |
  	currentColor ifNil: [^self].
  	"colorPatch color: currentColor.	May delete later"
  	(brushes isNil or: [brushes first owner ~~ self]) 
  		ifTrue: 
  			[brushes := OrderedCollection new.
  			#(#brush1: #brush2: #brush3: #brush4: #brush5: #brush6:) 
  				do: [:sel | brushes addLast: (self submorphNamed: sel)]].
+ 	brushes last offImage unhibernate.
+ 	brushes last onImage unhibernate.
+ 	brushes last pressedImage unhibernate.
+ 	center := brushes last offImage extent // 2.
+ 	offIndex := brushes last offImage pixelValueAt: center.
+ 	onIndex := brushes last onImage pixelValueAt: center.
- 	center := (brushes sixth) offImage extent // 2.
- 	offIndex := (brushes sixth) offImage pixelValueAt: center.
- 	onIndex := (brushes sixth) onImage pixelValueAt: center.
  	brushes do: 
  			[:bb | 
  			bb offImage colors at: offIndex + 1 put: currentColor.
  			bb offImage clearColormapCache.
  			bb onImage colors at: onIndex + 1 put: currentColor.
  			bb onImage clearColormapCache.
  			bb invalidRect: bb bounds].
  	self invalidRect: (brushes first topLeft rect: brushes last bottomRight)!



More information about the Squeak-dev mailing list