[squeak-dev] The Inbox: Monticello-cmm.579.mcz

Frank Shearar frank.shearar at gmail.com
Wed Dec 18 16:56:58 UTC 2013


On 18 December 2013 16:54,  <commits at source.squeak.org> wrote:
> A new version of Monticello was added to project The Inbox:
> http://source.squeak.org/inbox/Monticello-cmm.579.mcz
>
> ==================== Summary ====================
>
> Name: Monticello-cmm.579
> Author: cmm
> Time: 18 December 2013, 10:54:24.31 am
> UUID: 0d53b5d5-4955-4746-ab5d-9fab8fad410b
> Ancestors: Monticello-nice.578
>
> - When installing classes, ask EnvironmentRequest for the Environment to create in.
>         This lets MCEnvironmentLoadTest>>#testLoadIntoEnvironment pass.
>
> =============== Diff against Monticello-nice.578 ===============
>
> Item was changed:
>   ----- Method: MCClassDefinition>>createClass (in category 'installing') -----
>   createClass
>         | superClass class composition |
>         superClass := superclassName == #nil ifFalse:
>                                         [Smalltalk at: superclassName].
>         [class := (ClassBuilder new)
>                         name: name
> +                       inEnvironment: (EnvironmentRequest signal ifNil: [superClass environment])
> -                       inEnvironment: superClass environment
>                         subclassOf: superClass
>                         type: type
>                         instanceVariableNames: self instanceVariablesString
>                         classVariableNames: self classVariablesString
>                         poolDictionaries: self sharedPoolsString
>                         category: category.
>         ] on: Warning, DuplicateVariableError do:[:ex| ex resume].

Clearly when I took a run at implementing this, I went on a serious
wild goose chase or something. Because this looks like the obvious (in
hindsight) way to implement loading.

frank


More information about the Squeak-dev mailing list