[squeak-dev] The Trunk: Tests-fbs.279.mcz

commits at source.squeak.org commits at source.squeak.org
Fri Dec 20 13:18:13 UTC 2013


Frank Shearar uploaded a new version of Tests to project The Trunk:
http://source.squeak.org/trunk/Tests-fbs.279.mcz

==================== Summary ====================

Name: Tests-fbs.279
Author: fbs
Time: 20 December 2013, 1:17:52.91 pm
UUID: 19167fe5-6f98-4c43-bf95-cf38cd993cd1
Ancestors: Tests-fbs.278

Putting the supposedly empty collections in the assert's description means getting a jump start on debugging failures.

=============== Diff against Tests-fbs.278 ===============

Item was changed:
  ----- Method: ReleaseTest>>testClassesSystemCategory (in category 'testing') -----
  testClassesSystemCategory
  "Find cases where classes have nil system categories.
  This test will tell you the classes.
  This is inspired by the proposed fix of a bug in release of 3.10.1 
  see Mantis #7070" 
  | rejectClasses | 
  
  rejectClasses := 
   nil systemNavigation allClasses reject: [ :each |
  	each category notNil ] .
  
+ self assert: rejectClasses isEmpty description: ('Classes with nil system categories: {1}' format: {rejectClasses asCommaString}).!
- 
- self assert: rejectClasses isEmpty .
- 
- !

Item was changed:
  ----- Method: ReleaseTest>>testSuperSubclassReferences (in category 'testing') -----
  testSuperSubclassReferences
  	"see mantis bug 7090 for more info on this"
  	"If the reason for this test to fail is above bug, the following might fix the system"
  	"(ProtoObject subclasses reject: [:each | each isMeta or: [each environment includes: each]]) do: [:each | ProtoObject removeSubclass: each]"
+ 
+ 	| strangeClasses |
+ 	strangeClasses := ProtoObject allSubclasses reject: [:each | each isMeta or: [each environment includes: each]].
+ 	self assert: strangeClasses isEmpty description: ('Not expecting to find any of {1}' format: {strangeClasses asCommaString}).!
- 	
- 	self assert: (ProtoObject allSubclasses reject: [:each | each isMeta or: [each environment includes: each]]) isEmpty!

Item was changed:
  ----- Method: ReleaseTest>>testSystemCategoryClasses (in category 'testing') -----
  testSystemCategoryClasses
  "Find cases where system categories name absent classes.
  This test will tell you the classes.
  This is inspired by a bug in release of 3.10.1 
  see Mantis #7070" 
  |  rejectCats rejectClasses | 
  rejectCats := 
  SystemOrganization categories reject: [ :catName |
  	(SystemOrganization listAtCategoryNamed: catName) 
  		allSatisfy: [ :className | 
  			( Smalltalk includesKey: className ) ] ] .
  "self assert: rejectCats isEmpty ."
  
  rejectCats isEmpty ifTrue: [ ^ true ] . 
  
  
  rejectClasses :=
  rejectCats collect: [ :each |
  	each ->
  	( (SystemOrganization listAtCategoryNamed: each) 
  		reject: [ :eachOne | 
  			( Smalltalk includesKey: eachOne )  ] ) ] .
  
+ self assert: rejectCats isEmpty description: ('Not expecting any of {1}' format: { rejectClasses asCommaString}).
- self assert: rejectCats isEmpty .
  !



More information about the Squeak-dev mailing list