[squeak-dev] The Inbox: CommandLine-fbs.3.mcz

Frank Shearar frank.shearar at gmail.com
Mon Dec 30 20:34:48 UTC 2013


On 30 December 2013 20:27, Chris Muller <asqueaker at gmail.com> wrote:
> One issue is it doesn't do the opposite when starting headful.  If the
> headless image _saves_ and exits (a use-case I have now, today), then
> is relaunched headful later, the default ToolSet is not put back to
> the preferred headful tool.

Oh, I see what you mean. If you run headlessly, save & quit, and
launch headfully, you'll still have the CommandLineToolSet. Nice
catch.

> I think setting the CommandLineToolSet needs to be an explicit action
> by the command-line user, whether from the .st script or by virtue of
> using SmalltalkImage>>#run: (or equivalents).  Since that is part of
> the command-line interface so the user could expect command-line
> enhancements to be done.

Setting the ToolSet inside the .st script is a fail. I wasted hours
yesterday trying to debug the CI's release.st because the script _when
working_ takes an age to run, as it checks all packages for dirtiness.
The problem is that there was a missing [ in the script, and the only
way to find out that the script was _broken_ was to wait even longer.

So the point of the above commit is to ensure that _before the startup
script is run_ (i.e., before AutoStart starts up), that the
appropriate ToolSet is configured. Hence my attempt at signalling
which ToolSet to use through a command line option.

frank

> I think startup: should only do implementation-level stuff -- e.g.,
> unhibernating type activities.  Domain-level stuff (e.g., preferences
> and other image domain objects) should be controlled via explicitly by
> the user, such as through command-line arguments and/or .st script
> invoking a top-level method.
>
>
> On Mon, Dec 30, 2013 at 12:42 PM, Frank Shearar <frank.shearar at gmail.com> wrote:
>> On 30 December 2013 18:36,  <commits at source.squeak.org> wrote:
>>> A new version of CommandLine was added to project The Inbox:
>>> http://source.squeak.org/inbox/CommandLine-fbs.3.mcz
>>>
>>> ==================== Summary ====================
>>>
>>> Name: CommandLine-fbs.3
>>> Author: fbs
>>> Time: 30 December 2013, 6:36:22.399 pm
>>> UUID: a8ce5a55-8bb5-ac4b-a112-eb308ce3bf53
>>> Ancestors: CommandLine-fbs.2
>>>
>>> If launched headless (with option -headless or -vm-display-null), use the CommandLineToolSet instead of the StandardToolSet.
>>>
>>> We must startUp: before AutoStart because AutoStart triggers the processing of startup scripts (because it asks all registered AbstractLaunchers - in particular, ProjectLauncher - to do their thing).
>>>
>>> =============== Diff against CommandLine-fbs.2 ===============
>>
>> This allows headless things to report bad things happening, like
>> dumping syntax error notifications to stdout and exiting.
>>
>> frank
>>
>


More information about the Squeak-dev mailing list