OK, I'm startled to see this.

I'm trying to follow Frank's advice for submitting a small change;
a) I looked in the inbox repository and spotted Files-kfr.120.mcz
b) saw that it seemed to have some updates to the filedirectory stuff that my change relates to
c) merged it into my image
d) noted the MC browser displayed '* Files (kfr.120)' as I'd expect
e) realised it showed it only in Trunk
f) wondered what to do to save my working copy back to the inbox repository

And there I got a bit puzzled.

So far as I can tell I caused this email by copying the package that was already in inbox to … inbox. I doubt that is the right thing to do and it certainly seems to result in the wrong diff; nothing there about my change.

What am I supposed to do here? I not going to try copying the Files package from Trunk to inbox in case it moves the entire thing and screws life up later.


On 22-02-2013, at 11:54 PM, commits at source.squeak.org wrote:

> A new version of Files was added to project The Inbox:
> http://source.squeak.org/inbox/Files-kfr.120.mcz
> 
> ==================== Summary ====================
> 
> Name: Files-kfr.120
> Author: kfr
> Time: 12 November 2012, 6:23:28.531 pm
> UUID: 4a518133-203f-bd43-9fce-78b8dcfb337d
> Ancestors: Files-cmm.119
> 
> Fix for test failure on Windows
> 
> =============== Diff against Files-cmm.119 ===============
> 
> Item was added:
> + ----- Method: DosFileDirectory>>relativeNameIfAbsoluteFor: (in category 'path access') -----
> + relativeNameIfAbsoluteFor: aFileName
> + 	"Answer either the relative name for aFileName, if aFileName names a file in me or
> + 	 subdirectories, or aFileName's absolute path if it isn't in me or subdirectories.
> + 	 P.S. Ths is what I'd expect relativeNameFor: to do, but it is taken and means
> + 	 exactly the opposite, i.e. the absolute path for a relative name."
> + 	| fullNameSize fullName fileNameSize |
> + 	       (aFileName isEmpty or: [aFileName first ~= self driveName first]) ifTrue:
> +                 [self error: 'this method expects an absolute filename'].
> + 	fullNameSize := (fullName := self fullName) size.
> + 	fileNameSize := aFileName size.
> + 	^(aFileName beginsWith: fullName)
> + 		ifTrue: [(fileNameSize = fullNameSize
> + 				or: [fileNameSize - 1 = fullNameSize
> + 					and: [(aFileName at: fileNameSize) = self pathNameDelimiter]])
> + 					ifTrue: [self class currentDirectoryNickname]
> + 					ifFalse: [aFileName copyFrom: fullNameSize + 2 to: fileNameSize]]
> + 		ifFalse: [aFileName]
> + 
> + 	"SourceFiles asArray collect: [:sf| FileDirectory default relativeNameIfAbsoluteFor: sf fullName]"
> + 	"FileDirectory default relativeNameIfAbsoluteFor: FileDirectory default fullName" "should be dot"
> + 	"FileDirectory default relativeNameIfAbsoluteFor: FileDirectory default fullName, FileDirectory default slash" "should also be dot"!
> 
> 


tim
--
tim Rowledge; tim at rowledge.org; http://www.rowledge.org/tim
Useful Latin Phrases:- Raptus regaliter = Royally screwed