[squeak-dev] The Trunk: KernelTests-nice.244.mcz

Bob Arning arning315 at comcast.net
Sun Feb 24 11:15:55 UTC 2013


Ugly is the only valid criticism of

WriteStream on: ''

in Squeak, which I thought was the issue originally. Using a non-empty 
literal is, of course, asking for trouble. And if some code is becoming 
arguments passed to it from the outside, I think the problem may well 
lie with the receiver rather than the sender.

Cheers,
Bob

On 2/24/13 1:25 AM, tim Rowledge wrote:
> On 23-02-2013, at 5:34 PM, Eliot Miranda <eliot.miranda at gmail.com> wrote:
>
>> On Sat, Feb 23, 2013 at 4:08 PM, Bob Arning <arning315 at comcast.net> wrote:
>>> I tried it and did not see a problem. That is an empty string, isn't it?
>> Yes, and you're getting away with it because the WriteStream
>> implementation doesn't use become: to grow strings.  But back in the
>> day it did and would have resulted in a non-zero string.
>
> If Eliot's explanation doesn't convince you, just consider how ugly an expression it is. Let's have "WriteStream onNewString". Much more readable. Clearly expressed intent.
>
> tim
> --
> tim Rowledge; tim at rowledge.org; http://www.rowledge.org/tim
> "bOtHeR" said Pooh, mistaking the LSD tablet for aspirin
>
>
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20130224/c86ec50e/attachment.htm


More information about the Squeak-dev mailing list