[squeak-dev] The Trunk: CollectionsTests-nice.198.mcz

commits at source.squeak.org commits at source.squeak.org
Sun Feb 24 17:12:59 UTC 2013


Nicolas Cellier uploaded a new version of CollectionsTests to project The Trunk:
http://source.squeak.org/trunk/CollectionsTests-nice.198.mcz

==================== Summary ====================

Name: CollectionsTests-nice.198
Author: nice
Time: 24 February 2013, 6:12:35.434 pm
UUID: a4c370ec-5ddf-469a-aae4-1eb8c6d4fc02
Ancestors: CollectionsTests-fbs.197

Diminish excessive usage of ReadWriteStream

=============== Diff against CollectionsTests-fbs.197 ===============

Item was changed:
  ----- Method: CollectionTest>>testAsStringOnDelimiter (in category 'testing') -----
  testAsStringOnDelimiter
  	| delim |
  	delim := ', '.
  	{OrderedCollection new. Set new.} do:
  		[ :coll | | oneItemStream emptyStream multiItemStream |
+ 		emptyStream := String new writeStream.
- 		emptyStream := ReadWriteStream on: ''.
  		coll asStringOn: emptyStream delimiter: delim.
  		self assert: emptyStream contents = ''.
  
  		coll add: 1.
+ 		oneItemStream := String new writeStream.
- 		oneItemStream := ReadWriteStream on: ''.
  		coll asStringOn: oneItemStream delimiter: delim.
  		self assert: oneItemStream contents = '1'.
  
  		coll add: 2; add: 3.
+ 		multiItemStream := String new writeStream.
- 		multiItemStream := ReadWriteStream on: ''.
  		coll asStringOn: multiItemStream delimiter: ', '.
  		self assert: multiItemStream contents = '1, 2, 3'.]!

Item was changed:
  ----- Method: CollectionTest>>testAsStringOnDelimiterLast (in category 'testing') -----
  testAsStringOnDelimiterLast
  	| delim last |
  	delim := ', '.
  	last := ' & '.
  	{OrderedCollection new. Set new.} do:
  		[ :coll | | multiItemStream emptyStream oneItemStream |
+ 		emptyStream := String new writeStream.
- 		emptyStream := ReadWriteStream on: ''.
  		coll asStringOn: emptyStream delimiter: delim last: last.
  		self assert: emptyStream contents = ''.
  
  		coll add: 1.
+ 		oneItemStream := String new writeStream.
- 		oneItemStream := ReadWriteStream on: ''.
  		coll asStringOn: oneItemStream delimiter: delim last: last.
  		self assert: oneItemStream contents = '1'.
  
  		coll add: 2; add: 3.
+ 		multiItemStream := String new writeStream.
- 		multiItemStream := ReadWriteStream on: ''.
  		coll asStringOn: multiItemStream delimiter: ', ' last: last.
  		self assert: multiItemStream contents = '1, 2 & 3'.]!

Item was changed:
  ----- Method: CollectionTest>>testPrintOnDelimiter (in category 'testing') -----
  testPrintOnDelimiter
  	| delim |
  	delim := ', '.
  	{OrderedCollection new. Set new.} do:
  		[ :coll | | emptyStream oneItemStream multiItemStream |
+ 		emptyStream := String new writeStream.
- 		emptyStream := ReadWriteStream on: ''.
  		coll printOn: emptyStream delimiter: delim.
  		self assert: emptyStream contents = ''.
  
  		coll add: 1.
+ 		oneItemStream := String new writeStream.
- 		oneItemStream := ReadWriteStream on: ''.
  		coll printOn: oneItemStream delimiter: delim.
  		self assert: oneItemStream contents = '1'.
  
  		coll add: 2; add: 3.
+ 		multiItemStream := String new writeStream.
- 		multiItemStream := ReadWriteStream on: ''.
  		coll printOn: multiItemStream delimiter: ', '.
  		self assert: multiItemStream contents = '1'', ''2'', ''3'.]!

Item was changed:
  ----- Method: CollectionTest>>testPrintOnDelimiterLast (in category 'testing') -----
  testPrintOnDelimiterLast
  	| delim last |
  	delim := ', '.
  	last := ' & '.
  	{OrderedCollection new. Set new.} do:
  		[ :coll | | emptyStream oneItemStream multiItemStream |
+ 		emptyStream := String new writeStream.
- 		emptyStream := ReadWriteStream on: ''.
  		coll printOn: emptyStream delimiter: delim last: last.
  		self assert: emptyStream contents = ''.
  
  		coll add: 1.
+ 		oneItemStream := String new writeStream.
- 		oneItemStream := ReadWriteStream on: ''.
  		coll printOn: oneItemStream delimiter: delim last: last.
  		self assert: oneItemStream contents = '1'.
  
  		coll add: 2; add: 3.
+ 		multiItemStream := String new writeStream.
- 		multiItemStream := ReadWriteStream on: ''.
  		coll printOn: multiItemStream delimiter: ', ' last: last.
  		self assert: multiItemStream contents = '1'', ''2'' & ''3'.]!



More information about the Squeak-dev mailing list