[squeak-dev] The Trunk: Collections-cmm.499.mcz

Frank Shearar frank.shearar at gmail.com
Wed Jan 30 16:37:37 UTC 2013


On 29 January 2013 02:19,  <commits at source.squeak.org> wrote:
> Chris Muller uploaded a new version of Collections to project The Trunk:
> http://source.squeak.org/trunk/Collections-cmm.499.mcz
>
> ==================== Summary ====================
>
> Name: Collections-cmm.499
> Author: cmm
> Time: 28 January 2013, 8:19:08.858 pm
> UUID: 9af9bd27-3342-4203-88e5-22c85c57d5ae
> Ancestors: Collections-bf.498
>
> FloatCollection inherits the convenient add:/remove: API of OrderedCollection, but using an internal FloatArray for better efficiency.
>
> =============== Diff against Collections-bf.498 ===============
>
> Item was added:
> + OrderedCollection subclass: #FloatCollection
> +       instanceVariableNames: ''
> +       classVariableNames: ''
> +       poolDictionaries: ''
> +       category: 'Collections-Sequenceable'!
> +
> + !FloatCollection commentStamp: 'cmm 1/28/2013 19:49' prior: 0!
> + FloatCollctions store 32bit IEEE floating point numbers.!
>
> Item was added:
> + ----- Method: FloatCollection class>>arrayType (in category 'overriding') -----
> + arrayType
> +       ^ FloatArray!
>
> Item was added:
> + ----- Method: FloatCollection>>addLast: (in category 'as yet unclassified') -----
> + addLast: aFloat
> +       aFloat isNumber ifFalse: [ self error: 'This collection can only store Floats.' ].
> +       ^ super addLast: aFloat!

I just noticed that CI says you're wrong:
http://build.squeak.org/job/SqueakTrunk/lastBuild/testReport/junit/CollectionsTests.Sequenceable/FloatCollectionTest/testInternalArray/

Regressions:
FloatCollectionTest>>testInternalArray
FloatCollectionTest(ClassTestCase)>>testUnCategorizedMethods

(Well, I say "you're wrong" but this is just the most recent commit to
FloatCollection. You might be exposing a deficiency in the tests.)

frank


More information about the Squeak-dev mailing list