[squeak-dev] The Trunk: Network-fbs.142.mcz

Frank Shearar frank.shearar at gmail.com
Thu Jul 25 07:49:56 UTC 2013


On 25 July 2013 08:46,  <commits at source.squeak.org> wrote:
> Frank Shearar uploaded a new version of Network to project The Trunk:
> http://source.squeak.org/trunk/Network-fbs.142.mcz
>
> ==================== Summary ====================
>
> Name: Network-fbs.142
> Author: fbs
> Time: 25 July 2013, 8:46:43.161 am
> UUID: 6e2a56e3-7200-e843-976b-70b6a274d722
> Ancestors: Network-fbs.141
>
> SmalltalkImage current -> Smalltalk.
>
> =============== Diff against Network-fbs.141 ===============
>
> Item was changed:
>   ----- Method: InternetConfiguration class>>shutDown (in category 'system startup') -----
>   shutDown
> +       (Smalltalk platformName =  'Mac OS') ifTrue: [
> -       (SmalltalkImage current platformName =  'Mac OS') ifTrue: [
>                         HTTPSocket stopUsingProxyServer]
>
>   !
>
> Item was changed:
>   ----- Method: InternetConfiguration class>>startUp (in category 'system startup') -----
>   startUp
> +       (Smalltalk platformName =  'Mac OS') ifTrue: [
> -       (SmalltalkImage current platformName =  'Mac OS') ifTrue: [
>                 self useHTTPProxy ifTrue: [
>                          (self getHTTPProxyHost findTokens: ':') ifNotEmpty: [:p |
>                                 HTTPSocket useProxyServerNamed: p first port: p second asInteger]]]!

Checking for strings is... not the best thing you could do. I'd _much_
rather see something like "Smalltalk platform isMacOS" or similar.

frank


More information about the Squeak-dev mailing list