On Sat, Jun 22, 2013 at 4:34 AM, Frank Shearar <frank.shearar at gmail.com> wrote:
> Yes, it is :) Pushing a bunch of changes in the same commit means that
> a reviewer has to think too hard about what feature the different
> changes belong to.

I don't disagree with that, except there is no feature here.  This
change is the smallest possible change, deletion of a single
punctuation character from a single class comment.  I think there is a
middle-ground between that and "a bunch of changes".

> If our infrastructure can't handle this kind of thing, we should fix
> the infrastructure.

Indeed, but our unscalable infrastructure is not the only "cost".
Committing the deletion of one character spawns off e-mails which are
reviewed by everyone.  IMO, spelling or punctuation errors should not
even be explained in any version comments because it's obvious it was
wrong before, and so forever carrying around an explnation of it
basically amounts to "filler" in terms of future value of such a
comment.  At some time in the future, if we need to go back through
the history changes made to the System package to understand some
obscure bug that may have cropped up, the interest will be in the
_code_ changes.   If there are a lot of "non-changes" intermixed into
the ancestry list, it's juicy value is somewhat diluted.

> Also, this particular change was just something I noticed in passing.

I'll try not to harp on this anymore.  We all have our way of working
and while I don't see our contribution process as "free," it is
relatively lean, but if _thinking_ of it as free encourages
contribution, then that is certainly preferable.


>
> frank
>
> On 22 June 2013 00:45, Chris Muller <asqueaker at gmail.com> wrote:
>> Is such a small change like this worth pushing a whole new version of
>> System?  As often as you're making improvements, it seems like another
>> change to System package is bound to be right around the corner
>> anyway.  Perhaps piggy-backing this sort of micro-improvement with the
>> next improvement to System would be good?
>>
>> On Sat, Jun 15, 2013 at 10:20 AM,  <commits at source.squeak.org> wrote:
>>> Frank Shearar uploaded a new version of System to project The Trunk:
>>> http://source.squeak.org/trunk/System-fbs.548.mcz
>>>
>>> ==================== Summary ====================
>>>
>>> Name: System-fbs.548
>>> Author: fbs
>>> Time: 15 June 2013, 4:21:18.358 pm
>>> UUID: 162f5729-5ef9-48f5-8bb9-1a77deba7ecd
>>> Ancestors: System-fbs.547
>>>
>>> It's "its", not "it's". "It's" is a contraction of "it is".
>>>
>>> =============== Diff against System-fbs.547 ===============
>>>
>>> Item was changed:
>>>   Object subclass: #Clipboard
>>>         instanceVariableNames: 'contents recent interpreter'
>>>         classVariableNames: 'Default'
>>>         poolDictionaries: ''
>>>         category: 'System-Support'!
>>>
>>> + !Clipboard commentStamp: 'fbs 6/15/2013 16:20' prior: 0!
>>> - !Clipboard commentStamp: 'ul 8/20/2012 02:14' prior: 0!
>>>   The Clipboard class implements a basic buffering scheme for text. The currently selected text is also exported to the OS so that text can be copied from and to other applications. Commonly only a single instance is used (the default clipboard) but applications are free to use other than the default clipboard if necessary.
>>>
>>> + If you'd like to be notified of the changes of the clipboard, you can subscribe to its #contentChanged event. For example:
>>> - If you'd like to be notified of the changes of the clipboard, you can subscribe to it's #contentChanged event. For example:
>>>
>>>   subscriber := [ :newClipboardText :updateSource |
>>>         Transcript show: ('Clipboard was updated by {1}, the new content is: {2}'
>>>                 format: {
>>>                         updateSource.
>>>                         newClipboardText }); cr ].
>>>   Clipboard default
>>>         when: #contentChanged
>>>         send: #value:value:
>>>         to: subscriber.
>>>
>>>   At this point if you open a Transcript and copy or cut some text, then the message will appear on the Transcript. Make sure that there's a reference kept to subscriber, otherwise it will be garbage collected and no messages will appear.
>>>
>>>   To unsubscribe from the clipboard changes, just evaluate:
>>>
>>>   Clipboard default removeActionsWithReceiver: subscriber!
>>>
>>>
>>