[squeak-dev] The Trunk: Installer-Core-cmm.383.mcz

Chris Muller asqueaker at gmail.com
Tue Nov 12 16:40:01 UTC 2013


Addition-by-subtraction.  These methods overload an already overloaded
selector (#label) for stuff that was never really used.  Sake?
Universes?  Cruft?  Mantis?  SqueakMap vs. WebSqueakMap (what is
that?)?  Even if they were, when would we need to evaluate an
Installer's storeString?  I'm not seeing the usefulness, I see weeds.

If I'm wrong about that, bring back the functionality by overriding
#storeOn: and change printOn: to call storeOn: rather than this
proliferation of methods.

On Tue, Nov 12, 2013 at 3:44 AM, Frank Shearar <frank.shearar at gmail.com> wrote:
> On 11 November 2013 21:59,  <commits at source.squeak.org> wrote:
>> Chris Muller uploaded a new version of Installer-Core to project The Trunk:
>> http://source.squeak.org/trunk/Installer-Core-cmm.383.mcz
>>
>> ==================== Summary ====================
>>
>> Name: Installer-Core-cmm.383
>> Author: cmm
>> Time: 11 November 2013, 3:59:16.385 pm
>> UUID: 3844745d-bc14-44aa-adee-033cbc0ee3be
>> Ancestors: Installer-Core-cmm.382
>>
>> Installer simplification:  remove overly complex printing.
>>
>> =============== Diff against Installer-Core-cmm.382 ===============
>
> If I understand correctly, this simply removes _all_ printing, so an
> "i printString" (where i is an Installer) simply gives "an Installer"
> (or "an InstallerMonticello"). That doesn't seem like much of an
> improvement. The point of this implementation (spelling mistakes
> aside) seems to be to provide something like the MCRepository classes
> give - to give you a string that, when evaluated, gives you an
> equivalent Installer. I rather like that behaviour. It seems
> unfortunate to lose such a useful thing.
>
> frank
>


More information about the Squeak-dev mailing list