[squeak-dev] The Trunk: Collections-cmm.538.mcz

Chris Muller asqueaker at gmail.com
Tue Oct 1 16:21:03 UTC 2013


So I guess we have 24 senders of #endEntry most of which should
probably be sending #flush instead.

On Tue, Oct 1, 2013 at 10:56 AM, Levente Uzonyi <leves at elte.hu> wrote:
> On Tue, 1 Oct 2013, commits at source.squeak.org wrote:
>
>> Chris Muller uploaded a new version of Collections to project The Trunk:
>> http://source.squeak.org/trunk/Collections-cmm.538.mcz
>>
>> ==================== Summary ====================
>>
>> Name: Collections-cmm.538
>> Author: cmm
>> Time: 30 September 2013, 7:50:52.954 pm
>> UUID: f041f162-9c02-499f-866e-27d2e1a31b6b
>> Ancestors: Collections-tpr.537
>>
>> - Logging output to a #endEntry is sometimes necessary.  So let's still
>> allow switching to another kind of WriteStream.
>
>
> I don't see the point of this change. #flush is part of the Stream protocol,
> so it's definitely not a compatibility method in WriteStream.
> It's better to use #flush instead of #endEntry, because all streams
> understand #flush, but only Transcript (and now WriteStream) understands
> #endEntry.
>
>
> Levente
>
>
>>
>> =============== Diff against Collections-tpr.537 ===============
>>
>> Item was added:
>> + ----- Method: WriteStream>>endEntry (in category 'compatibility') -----
>> + endEntry
>> +       "No-op for compatibility with TranscriptStream."!
>>
>> Item was changed:
>> + ----- Method: WriteStream>>flush (in category 'compatibility') -----
>> - ----- Method: WriteStream>>flush (in category 'file open/close') -----
>>  flush!
>>
>>
>>
>


More information about the Squeak-dev mailing list