endEntry is, though, essentially obsolete.  flush is better; it's more
flexible because it works with Transcript and streams, and has a more
generally understood meaning.  So I'd like to see endEntry deprecated.


On Tue, Oct 1, 2013 at 9:37 AM, Levente Uzonyi <leves at elte.hu> wrote:

> I don't think that #endEntry should be private. AFAIK Transcript wasn't
> always a stream, and #endEntry was part of Transcript's original protocol.
> If you check the senders of #endEntry, then you'll find that the receiver
> is always "Transcript" or "self". Replacing #endEntry with #flush won't
> hurt in most cases.
>
>
> Levente
>
>
> On Tue, 1 Oct 2013, Chris Muller wrote:
>
>  I had not noticed the existence of TranscriptStream>>#flush.  Clearly,
>> TranscriptStream>>#endEntry is miscategorized then -- it should be
>> private, should it not?
>>
>> My version comment was intended to say:  "When Logging output to a
>> TranscriptStream, #endEntry is sometimes necessary.  So let's still
>> allow switching to another kind of WriteStream."
>>
>> Since flush is available, you're right, we don't need it on
>> WriteStream.  I'll remove it when I get a chance.
>>
>>
>> On Tue, Oct 1, 2013 at 10:56 AM, Levente Uzonyi <leves at elte.hu> wrote:
>>
>>> On Tue, 1 Oct 2013, commits at source.squeak.org wrote:
>>>
>>>  Chris Muller uploaded a new version of Collections to project The Trunk:
>>>> http://source.squeak.org/**trunk/Collections-cmm.538.mcz<http://source.squeak.org/trunk/Collections-cmm.538.mcz>
>>>>
>>>> ==================== Summary ====================
>>>>
>>>> Name: Collections-cmm.538
>>>> Author: cmm
>>>> Time: 30 September 2013, 7:50:52.954 pm
>>>> UUID: f041f162-9c02-499f-866e-**27d2e1a31b6b
>>>> Ancestors: Collections-tpr.537
>>>>
>>>> - Logging output to a #endEntry is sometimes necessary.  So let's still
>>>> allow switching to another kind of WriteStream.
>>>>
>>>
>>>
>>> I don't see the point of this change. #flush is part of the Stream
>>> protocol,
>>> so it's definitely not a compatibility method in WriteStream.
>>> It's better to use #flush instead of #endEntry, because all streams
>>> understand #flush, but only Transcript (and now WriteStream) understands
>>> #endEntry.
>>>
>>>
>>> Levente
>>>
>>>
>>>
>>>> =============== Diff against Collections-tpr.537 ===============
>>>>
>>>> Item was added:
>>>> + ----- Method: WriteStream>>endEntry (in category 'compatibility')
>>>> -----
>>>> + endEntry
>>>> +       "No-op for compatibility with TranscriptStream."!
>>>>
>>>> Item was changed:
>>>> + ----- Method: WriteStream>>flush (in category 'compatibility') -----
>>>> - ----- Method: WriteStream>>flush (in category 'file open/close') -----
>>>>  flush!
>>>>
>>>>
>>>>
>>>>
>>>
>>
>>
>


-- 
best,
Eliot
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20131002/fd93b57f/attachment.htm