[squeak-dev] The Trunk: Collections-cmm.541.mcz

Frank Shearar frank.shearar at gmail.com
Tue Oct 15 21:40:07 UTC 2013


On 15 October 2013 20:09,  <commits at source.squeak.org> wrote:
> Chris Muller uploaded a new version of Collections to project The Trunk:
> http://source.squeak.org/trunk/Collections-cmm.541.mcz
>
> ==================== Summary ====================
>
> Name: Collections-cmm.541
> Author: cmm
> Time: 15 October 2013, 2:08:54.58 pm
> UUID: 412ef59f-6c4a-4844-94b8-137546e2f0f0
> Ancestors: Collections-nice.540
>
> - Revert addition of WriteStream>>#endEntry.
> - Fix to recent Transcripter change.
>
> =============== Diff against Collections-nice.540 ===============
>
> Item was changed:
>   ----- Method: Transcripter>>readEvalPrint (in category 'command line') -----
>   readEvalPrint
>         | line okToRevert |
>         okToRevert := true.
>         [#('quit' 'exit' 'done' ) includes: (line := self request: '>')]
>                 whileFalse:
>                 [line = 'revert'
>                 ifTrue: [okToRevert
> +                       ifTrue: [RecentMessages default revertMostRecent.
> -                       ifTrue: [RecentMessages default revertLastMethodSubmission.
>                                         self cr; show: 'reverted: ' , RecentMessages default mostRecent.
>                                         okToRevert := false]

I realise I'm the guy who touched this last, but it looks completely
wrong. I mean, the new name's an improvement. But we revert the most
recent submission, and then say that we reverted the _new_ most recent
submission... which was surely the _second_ most recent submission?!

Maybe that block needs to say

    ifTrue: [ |reverted|
        reverted := RecentMessages default mostRecent.
        RecentMessages default revertMostRecent.
        self cr; show: 'reverted: ', reverted printString.
        okToRevert := false]

?

frank


More information about the Squeak-dev mailing list