[squeak-dev] The Trunk: System-cmm.610.mcz

Levente Uzonyi leves at elte.hu
Thu Oct 31 17:35:36 UTC 2013


On Thu, 31 Oct 2013, Chris Muller wrote:

> But MultiByteFileStream is-a StandardFileStream.

Right, but this case is just an example of misuse of inheritance instead 
of encapsulation.


Levente

>
> On Wed, Oct 30, 2013 at 10:46 PM, Levente Uzonyi <leves at elte.hu> wrote:
>> On Wed, 30 Oct 2013, Chris Muller wrote:
>>
>>> Indeed.  OTOH, stdout and stderr ARE kinds of StandardFileStreams so I
>>> question whether the location of _those_ accessors is appropriate, or
>>> whether they should be on StandardFileStream..?
>>
>>
>> You should use FileStream. The class of the actual streams depends on the
>> value of the #encodeAndDecodeStdioFiles preference. Its value is true by
>> default, which means that streams should be instances of
>> MultiByteFileStream. If they are StandardFileStreams in your image, then you
>> have changed the value of the preference.
>>
>>
>> Levente
>>
>>
>>>
>>>
>>> On Wed, Oct 30, 2013 at 5:09 PM, Frank Shearar <frank.shearar at gmail.com>
>>> wrote:
>>>>
>>>> On 26 October 2013 20:17,  <commits at source.squeak.org> wrote:
>>>>>
>>>>> Chris Muller uploaded a new version of System to project The Trunk:
>>>>> http://source.squeak.org/trunk/System-cmm.610.mcz
>>>>>
>>>>> ==================== Summary ====================
>>>>>
>>>>> Name: System-cmm.610
>>>>> Author: cmm
>>>>> Time: 26 October 2013, 2:17:09.114 pm
>>>>> UUID: a27149c5-0fd6-4bef-a34a-57db707aec83
>>>>> Ancestors: System-dtl.609
>>>>>
>>>>> Consider valueWithAllPossibleArguments: special enough to inline, for
>>>>> now.
>>>>>
>>>>> =============== Diff against System-dtl.609 ===============
>>>>
>>>>
>>>> Why "StandardFileStream stdout" and not "FileStream stdout"? The
>>>> latter is shorter and more abstract.
>>>>
>>>> frank
>>>>
>>>
>>>
>>
>


More information about the Squeak-dev mailing list