[squeak-dev] The Inbox: System-fbs.595.mcz
frank.shearar at gmail.com
Thu Sep 19 21:33:03 UTC 2013
On 19 September 2013 22:28, <commits at source.squeak.org> wrote:
> A new version of System was added to project The Inbox:
> ==================== Summary ====================
> Name: System-fbs.595
> Author: fbs
> Time: 19 September 2013, 10:28:26.089 pm
> UUID: ce3d56a2-594f-764a-9abf-37009e28b231
> Ancestors: System-fbs.594
> Remove all tracking of recent method submission from Utilities, putting it into a separate RecentMessages object.
> Leave some deprecated stubs in place for things still expecting the Utilities facilities.
> Note the stubby Environment awareness in ChangeRecord and friends. These preserve the behaviour of #fileIn putting things in Smalltalk globals, while still allowing you to specify an Environment. (This seemed less invasive than throwing EnvironmentRequests.) We need this because recent method submissions should not cross Environment boundaries - when we make a method submission, we should track in which Environment you made the change (through AbstractEvent >> #environment:)
> =============== Diff against System-fbs.594 ===============
As threatened, I finally beat my submission into shape. This is the
next step in the elimination of Utilities, or at least those parts of
Utilities that belong in separate objects.
Adding this to trunk will mean a bunch of other small commits to
Monticello, Collections (!) and so on. There's also a fairly
comprehensive test suite for RecentMessages. Almost certainly not
exhaustive, but there are tests for things like reverting the last
change, and loading things into environments.
Please take a look, and let me know what you think. There's a fair
amount of code, but the idea is simple enough: pull everything around
tracking recent method submissions out of Utilities and into a
separate, self-contained object.
Oh, one thing: there's a change in the preamble to stop the change
notifications going to Utilities. RecentMessages class >> #startUp
will route the notifications to the replacement, RecentMessages
More information about the Squeak-dev