Thanks Yoshiki, that's helpful.
So, EncodedCharSet is currently used, but that should better be the
LanguageEnvironment (or a more specialized house rule).
And isBreakable should at least look at a pair of chars (if lines cannot
end with prev, or line cannot start with next, or the pair is unbreakable,
etc...).
Since you have very accurate names for it, it would be nice to see methods
spelled with latin transliteration oikomi oidashi etc... :)


2013/9/25 Yoshiki Ohshima <Yoshiki.Ohshima at acm.org>

> At Tue, 24 Sep 2013 23:21:00 +0200,
> Nicolas Cellier wrote:
> >
> > 2013/9/21 tim Rowledge <tim at rowledge.org>
> >
> > >
> > > a) There are {language}environment classes and encoding classes. There
> is
> > > #isBreakableAt:in: implemented in both but seemingly unused in the
> encoding
> > > classes because it is just plain broken there. Should it be removed
> from
> > > the encoders? In the language environment classes it is implemented to
> > > return true for space and cr by default, but space, cr & lf in Latin1
> and
> > > Latin2. Is that as expected?
> > >
> > >
> > >From what I understand:
> > - no need to answer true for space, cr, lf since these are already
> handled
> > in the CharacterScanner stopConditions, so default answer should be
> ^false
> > (unless one of these is removed from stopConditions, I thought I saw
> that,
> > but cannot remember...)
> > - whether it should be in EncodedCharSet or LanguageEnvironment, I don't
> > know...
> >
> > I don't completely like the Multi* version...
> > For example, when the last breakable char is not a space, there is no
> > adjustment of space width.
> > Maybe Justified makes no sense in Japanese?
> > I'd very much like to have tests describing the exepectations...
> >
>
> Having tests would have been good, yes.  For some reference this might
> help a bit.  The page rightly mentions contradicting "House Rules" so
> it is not clear cut.
>
> http://en.wikipedia.org/wiki/Line_breaking_rules_in_East_Asian_languages
>
> I'd support a rewrite of the whole thing, and perhaps would do more
> "total rewrite" approach...
>
> -- Yoshiki
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20130925/b89f60f6/attachment-0001.htm