[squeak-dev] The Trunk: Multilingual-tpr.177.mcz

tim Rowledge tim at rowledge.org
Fri Sep 27 00:38:19 UTC 2013


On 26-09-2013, at 5:19 PM, Nicolas Cellier <nicolas.cellier.aka.nice at gmail.com> wrote:

> I don't understand all you did...
> #scanSelector is still in use sent by #scanSelectorAt:.
> This is because #charsetAt: can answer either a LanguageEnvironment or an EncodedCharSet, so why remove it now?

It's just the non-used method in EncodedCharSet class.

> 
> Why remove #isBreakable:in:in:? it is still in use by the scanJapanese...
> same for breakAtSpace (for Japanese only).

I didn't remove the method completely - there is an identical version in MultiCharacterScanner for it to inherit. 


> 
> Why remove composeFrom: startIndex inRectangle: snip... ?
> I'm suspect that this is a slip due to moving methods between packages

Certainly a mistake somewhere to do with moving stuff.


tim
--
tim Rowledge; tim at rowledge.org; http://www.rowledge.org/tim
Oxymorons: Clearly misunderstood




More information about the Squeak-dev mailing list