[squeak-dev] The Trunk: Multilingual-tpr.177.mcz

Nicolas Cellier nicolas.cellier.aka.nice at gmail.com
Fri Sep 27 00:50:52 UTC 2013


2013/9/27 tim Rowledge <tim at rowledge.org>

>
> On 26-09-2013, at 5:19 PM, Nicolas Cellier <
> nicolas.cellier.aka.nice at gmail.com> wrote:
>
> > I don't understand all you did...
> > #scanSelector is still in use sent by #scanSelectorAt:.
> > This is because #charsetAt: can answer either a LanguageEnvironment or
> an EncodedCharSet, so why remove it now?
>
> It's just the non-used method in EncodedCharSet class.
>
> But these are all class methods... charsetAt: answers a class, not an
instance...
So JISX0208 won't understand scanSelector if ever you introduce leadingChar
= 4...


> >
> > Why remove #isBreakable:in:in:? it is still in use by the scanJapanese...
> > same for breakAtSpace (for Japanese only).
>
> I didn't remove the method completely - there is an identical version in
> MultiCharacterScanner for it to inherit.
>
> OK, my bad, I saw that after posting


>
> >
> > Why remove composeFrom: startIndex inRectangle: snip... ?
> > I'm suspect that this is a slip due to moving methods between packages
>
> Certainly a mistake somewhere to do with moving stuff.
>
>
> Yes, my own fault, the update was not ready.



> tim
> --
> tim Rowledge; tim at rowledge.org; http://www.rowledge.org/tim
> Oxymorons: Clearly misunderstood
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20130927/1915a779/attachment.htm


More information about the Squeak-dev mailing list