[squeak-dev] Fixing overwritten initials in the image (was: Sound playing can break in odd manner)

Eliot Miranda eliot.miranda at gmail.com
Sun Dec 7 04:04:21 UTC 2014


On Sat, Dec 6, 2014 at 5:53 PM, Chris Muller <asqueaker at gmail.com> wrote:

> Oh yes that's the best source; the original.  Maybe it can be rolled
> into as part of a new .changes / .sources for the 4.6 / 5.0 release.
> I liked the last thing Eliot said about it (a while back) that we
> could keep all history, just get rid of the "leaves".  Does anyone
> remember the status of #condenseSources and #condenseChanges?  Do they
> just work or is there some issue which was the reason we haven't done
> it in so long?
>

I believe they still work.  I also have changes that work that implement
getting rid of the leaves.  I hear that there's better engineered code in
Pharo too.


> On Sat, Dec 6, 2014 at 3:32 PM, Bert Freudenberg <bert at freudenbergs.de>
> wrote:
> > Actually we just need to take a sources/changes file from before
> 11/20/2005 and compare all methods to the current ones ...
> >
> > - Bert -
> >
> >> On 06.12.2014, at 22:20, Chris Muller <asqueaker at gmail.com> wrote:
> >>
> >> Yes, I guess I didn't realize we had overwritten initials because I
> >> remember doing the FixUnderscores improvement myself to preserve the
> >> initials.  Wait..
> >>
> >> (CompiledMethod allInstances collect: [ : e | e timeStamp ] as: Bag)
> >> sortedCounts first: 10
> >>
> >> Dang.  So, yeah, it looks like quite a few method's original
> >> authorship information got trampled.  Unfortunately, the 'mc history'
> >> function can only show what was actually _loaded_ into that DB.  IOW,
> >> we have to have the .mcz's for the versions that were BEFORE 2/4/2006
> >> 20:41.  The oldest one we have in trunk is
> >>
> >> Name: Sound-md.6
> >> Author: md
> >> Time: 21 April 2006, 5:05:36 pm
> >> UUID: 498cd464-d148-11da-a5e8-000d933a223c
> >> Ancestors: Sound-md.5
> >>
> >> which carries the same version of that method.
> >>
> >> But at least we can identify the worst-offending methods (the list
> >> above), so that maybe they could be extracted from an old image or
> >> maybe Bob's history thing??
> >>
> >>
> >> On Sat, Dec 6, 2014 at 2:20 PM, David T. Lewis <lewis at mail.msen.com>
> wrote:
> >>> On Fri, Dec 05, 2014 at 12:23:09PM +0100, Bert Freudenberg wrote:
> >>>> On 05.12.2014, at 04:11, tim Rowledge <tim at rowledge.org> wrote:
> >>>>>
> >>>>> (Stephane added explicitly since the code has his initials)
> >>>>
> >>>> We can't rely on the initials unfortunately - this is from when we
> converted underscore assignments to colon-equals, which originally did not
> preserve initials.
> >>>>
> >>>> It would actually be a very useful project for someone to fix this:
> write a snippet that goes through every method, compares it to its previous
> version (using Chris's MC history thingy for example), and if the only
> change is that ':=' replaced '_' then restore the previous time stamp.
> >>>>
> >>>> - Bert -
> >>>
> >>>
> >>> This is a really good idea, so I am replying with a new subject line in
> >>> hopes of encouraging follow up.
> >>>
> >>> Dave
> >>>
> >>>
> >>
> >
> >
> >
> >
> >
> >
>
>


-- 
best,
Eliot
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20141206/98b0b549/attachment.htm


More information about the Squeak-dev mailing list