[squeak-dev] The Inbox: CollectionsTests-dtl.209.mcz

Frank Shearar frank.shearar at gmail.com
Fri Jan 3 19:11:26 UTC 2014


On 2 January 2014 20:55,  <commits at source.squeak.org> wrote:
> David T. Lewis uploaded a new version of CollectionsTests to project The Inbox:
> http://source.squeak.org/inbox/CollectionsTests-dtl.209.mcz
>
> ==================== Summary ====================
>
> Name: CollectionsTests-dtl.209
> Author: dtl
> Time: 2 January 2014, 3:55:41.062 pm
> UUID: 5681f129-af93-4f97-9449-b2391be6c8a3
> Ancestors: CollectionsTests-fbs.208
>
> Provide TextAttributesScanningTest to verify text attribute filein and fileout.
>
> Five tests are marked as expected failures. These are tests for text attributes that are apparently unused, and that are likely candidates for removal from the image.
>
> There is one failure in a test for PluggableTextAttribute, which is a kind of text attribute that is used by SqueakMap. This is probably a legitimate failure that should be fixed.
>
> =============== Diff against CollectionsTests-fbs.208 ===============
<snip>
> Item was added:
> + ----- Method: TextAttributesScanningTest>>testTextAttributeClassFor (in category 'testing') -----
> + testTextAttributeClassFor
> +       "Verify class identifiers as used in RunArray class>>scanFrom:"
> +
> +       self assert: (TextAttribute classFor: $a) equals: TextAlignment.
> +       self assert: (TextAttribute classFor: $f) equals: TextFontChange.
> +       self assert: (TextAttribute classFor: $F) equals: TextFontReference.
> +       self assert: (TextAttribute classFor: $b) equals: TextEmphasis.
> +       self assert: (TextAttribute classFor: $i) equals: TextEmphasis.
> +       self assert: (TextAttribute classFor: $u) equals: TextEmphasis.
> +       self assert: (TextAttribute classFor: $=) equals: TextEmphasis.
> +       self assert: (TextAttribute classFor: $n) equals: TextEmphasis.
> +       self assert: (TextAttribute classFor: $-) equals: TextKern.
> +       self assert: (TextAttribute classFor: $+) equals: TextKern.
> +       self assert: (TextAttribute classFor: $c) equals: TextColor.
> +       self assert: (TextAttribute classFor: $L) equals: TextLink.
> +       self assert: (TextAttribute classFor: $R) equals: TextURL.
> +       self assert: (TextAttribute classFor: $q) equals: TextSqkPageLink.
> +       self assert: (TextAttribute classFor: $p) equals: TextSqkProjectLink.
> +       self assert: (TextAttribute classFor: $P) equals: TextPrintIt.
> +       self assert: (TextAttribute classFor: $d) equals: TextDoIt.

Yay for #assert:equals:! The expected value goes first, though:
otherwise you get a message something like "Expected actualValue but
was expectedValue". The same applies, as far as I can see, to the
other #assert:equals: calls.

frank


More information about the Squeak-dev mailing list