[squeak-dev] Daily Commit Log

commits at source.squeak.org commits at source.squeak.org
Tue May 6 23:55:02 UTC 2014


Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours:

http://lists.squeakfoundation.org/pipermail/packages/2014-May/007020.html

Name: Morphic-eem.724
Ancestors: Morphic-eem.723

Fix displaying the project name in the middle of the docking bar.

=============================================

http://lists.squeakfoundation.org/pipermail/packages/2014-May/007021.html

Name: Compression-eem.41
Ancestors: Compression-fbs.40

Fix a bug in [Fast]InflateStream, thanks to Yoshiki Oshima:

This can be a nitpick of the year, but there is a bug in
InflateStream>>decompressBlock:with:

There is a part that reads (toward the end):

------------------------
collection
        replaceFrom: readLimit+1
        to: readLimit + length + 1
        with: collection
        startingAt: readLimit - distance + 1.
------------------------

but here we want to replace "length" bytes in collection, as opposed
to length + 1 bytes, so it has to say:

------------------------
collection
        replaceFrom: readLimit+1
        to: readLimit + length
        with: collection
        startingAt: readLimit - distance + 1.
------------------------

(So is the non-primitive version in FastInflateStream.)

The reason it does not matter is that replaceFrom:to:with:startingAt:
does not care about the source and destination being the same and
overlap between them.  Even when the above bug puts one extra bytes in
collection temporarily, the extra byte will be wiped out in the next
iteration of the loop surrounding it.  However, if you try to port
this to a language that does the "right thing" when there is an
overlap, it manifests as a bug.

-- Yoshiki

P.S.
It was a "rare" delight to point out a bug in Andreas' code^^; We miss
you.

=============================================

http://lists.squeakfoundation.org/pipermail/packages/2014-May/007022.html

Name: Collections-dtl.568
Ancestors: Collections-eem.567

Add a flush to WriteStream>>nextChunkPut:

This is a workaround for a bug in the runtime library of some versions of Ubuntu. The symptom is that creation of a class comment for a class that previously had no comment leads to a file size error in the new RemoteStream that points to the class comment. Actual file size and contents of the changes file are not affected by this bug, and the error occurs when reading contents of the changes file immediately following the initial save, Flushing the stream after writing a chunk to the changes file prevents the problem.

=============================================


More information about the Squeak-dev mailing list