[squeak-dev] The Inbox: ShoutCore-cmm.45.mcz

Chris Muller asqueaker at gmail.com
Wed Apr 8 19:30:11 UTC 2015


>> A new version of ShoutCore was added to project The Inbox:
>> http://source.squeak.org/inbox/ShoutCore-cmm.45.mcz
>>
>> ==================== Summary ====================
>>
>> Name: ShoutCore-cmm.45
>> Author: cmm
>> Time: 6 April 2015, 5:52:19.582 pm
>> UUID: 7f2c4864-c8d9-4f51-8553-23db02266ad0
>> Ancestors: ShoutCore-cmm.44
>>
>> - Added subdued version of Shout colors proposed in cmm.44.
>> - #defaultStyleTable is misnamed because it was was not the default.  Renamed it to #brightStyleTable.
>> - Simplify help text for #subduedSyntaxHighlights.
>>
>
> Did you integrate you changes into the subdued style now?
> Please leave the subdued style.
>         Maybe we should allow for several styles?
>
>
> Personally, I don't like the color choice yo are proposing, too much green,

Well it's actually "green duller duller muchDarker" and its ONLY for
unary and keyword messages.

By contrast, the existing subdued table uses a 100%-saturation blue
for not only messages, but also symbols (which should be black),
literal-arrays (which should not be the same color as code!), AND
method and block arguments.  So it has a lot more blue than the new
one has green.  Why so much blue?

> too hard to figure out at a glance the proportions of the following concepts:
>
> "direct access" (instvars, classes, formerly black) vs
> "messages" (formerly blueish),
> "self/supers" (formerly reddish)

In fact, "at a glance" is one of the primary motivations for the new
palette, and why I personally use bold black for self and super.  But
I turned off the emphasis in this subdued for Levente (maybe a
different color then?).

Messages are visible at-a-glance because they're the only thing that's green.

Finally, I like to see inst-vars access at a glance too.  In the
existing table, you cannot distinguish between *local* access and
*global* access at a glance, because it paints inst-vars and classes
the same color.  And method-args the same color as Symbols.

> The proportions of the three rather distinct colors gave me a subconscious hint,
> whether the method was idiomatic or not…

I know what you mean, but I think the existing table is much less
effective at it.  Plus, it's hideous.

> Also, please be very careful with underlining. The once only bolded message name
> is now bold AND green AND underlined. Thats a tad too much attention. Moreover,
> UML uses underlining for 'static methods' aka class methods. this could be confusing.

Sure, no problem.  As I said, I turned off some of the emphasis to try
to win Levente's support.  I don't want my own personal colors, just
anything other than what we currently have for the default.

> Don't get me wrong, I _like_ a variety of syntax highlighting styles, we
> should support that better. I, however, don't think it is a good idea to
> override a relatively accustomed style just because "it's time for a change".

That's not the only reason, the existing tables have a lot of problems, IMO.


More information about the Squeak-dev mailing list