[squeak-dev] WeakArray species (was The Trunk: Collections-bf.612.mcz)

Bert Freudenberg bert at freudenbergs.de
Thu Apr 9 10:03:14 UTC 2015


On 08.04.2015, at 18:03, Chris Muller <asqueaker at gmail.com> wrote:
> 
> The impetus for the change was so that (WeakArray new = Array new)
> would return true instead of false.  But we could accomplish that by
> overriding #= instead of #species, I think..
> 
> Do you think overriding #species in WeakArray at this point in the
> release process is too aggressive?

Not sure. The #testNoObsoleteClasses test is still failing, even though there were fewer obsolete classes when we fixed WeakArray>>copyWith:. Would reverting #species help fix these for good?

- Bert -

> On Wed, Apr 8, 2015 at 6:16 AM, Bert Freudenberg <bert at freudenbergs.de> wrote:
>> On 08.04.2015, at 04:45, Chris Muller <asqueaker at gmail.com> wrote:
>>> 
>>> The change to override #species may not have gotten enough scrutiny.
>>> It was a mere mention by Eliot in a prior thread, which I captured
>>> into Collections-cmm.603.  It may be worth some additional peer
>>> scrutiny.  It feels right on the surface but could such a change cause
>>> negative impacts elsewhere?
>> 
>> Oh, that was a recent change? I wondered why we never noticed the problems before. That explains it.
>> 
>> - Bert -
>> 



-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4115 bytes
Desc: not available
Url : http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20150409/f4667dac/smime.bin


More information about the Squeak-dev mailing list