[squeak-dev] The Trunk: Collections-nice.622.mcz

commits at source.squeak.org commits at source.squeak.org
Thu Apr 30 22:41:52 UTC 2015


Nicolas Cellier uploaded a new version of Collections to project The Trunk:
http://source.squeak.org/trunk/Collections-nice.622.mcz

==================== Summary ====================

Name: Collections-nice.622
Author: nice
Time: 1 May 2015, 12:40:25.475 am
UUID: 93c764da-c5b6-4fa6-aa98-a9ad54611907
Ancestors: Collections-mt.621

#toBraceStack: is not used for compiling { } for so long that it's really time to get rid of it.

Symbol>>numArgs: does not need to copy self into a temp var.

=============== Diff against Collections-mt.621 ===============

Item was removed:
- ----- Method: Collection>>toBraceStack: (in category 'private') -----
- toBraceStack: itsSize 
- 	"Push receiver's elements onto the stack of thisContext sender.  Error if receiver does
- 	 not have itsSize elements or if receiver is unordered.
- 	 Do not call directly: this is called by {a. b} := ... constructs."
- 
- 	self size ~= itsSize ifTrue:
- 		[self error: 'Trying to store ', self size printString,
- 					' values into ', itsSize printString, ' variables.'].
- 	thisContext sender push: itsSize fromIndexable: self!

Item was changed:
  ----- Method: Symbol>>numArgs: (in category 'system primitives') -----
  numArgs: n
  	"Answer a string that can be used as a selector with n arguments.
  	 TODO: need to be extended to support shrinking and for selectors like #+ " 
  
+ 	| numArgs aStream offs |.
+ 	(numArgs := self numArgs) >= n ifTrue: [^self].	
- 	| selector numArgs aStream offs |
- 	
- 	selector := self.
- 	(numArgs := selector numArgs) >= n ifTrue: [^self].	
  	aStream := WriteStream on: (String new: 16).
  	aStream nextPutAll: self.
  	
  	(numArgs = 0) ifTrue: [aStream nextPutAll: ':'. offs := 0] ifFalse: [offs := 1].
  	2 to: n - numArgs + offs do: [:i | aStream nextPutAll: 'with:'].	
+ 	^aStream contents asSymbol!
- 	^aStream contents asSymbol
- 	
- !



More information about the Squeak-dev mailing list