[squeak-dev] The Trunk: Kernel-cmm.937.mcz

Tobias Pape Das.Linux at gmx.de
Thu Aug 6 16:40:03 UTC 2015


On 06.08.2015, at 18:29, Levente Uzonyi <leves at elte.hu> wrote:

> I still think that we shouldn't use the Environments' Dictionary API in new code. IMHO #classNamed: is the right selector to use here:
> 
> 	(self class environment classNamed: #BreakpointManager) ifNotNil: [ :breakPointManager |
> 		^breakPointManager methodHasBreakpoint: self ].
> 	^false

Then again, nil checks aren't nice code, either…

Best regards
	-Tobias

> 
> Levente
> 
> On Thu, 6 Aug 2015, commits at source.squeak.org wrote:
> 
>> Chris Muller uploaded a new version of Kernel to project The Trunk:
>> http://source.squeak.org/trunk/Kernel-cmm.937.mcz
>> 
>> ==================== Summary ====================
>> 
>> Name: Kernel-cmm.937
>> Author: cmm
>> Time: 5 August 2015, 8:06:28.072 pm
>> UUID: 191e34d9-22d7-4e46-ac5d-cb3cd9baf203
>> Ancestors: Kernel-cmm.936
>> 
>> - #hasBreakpoint is now needed by Kernel, but must be able to operate independently of System's BreakpointManager.
>> 
>> =============== Diff against Kernel-cmm.936 ===============
>> 
>> Item was changed:
>> + ----- Method: CompiledMethod>>hasBreakpoint (in category '*Kernel-tool support') -----
>> - ----- Method: CompiledMethod>>hasBreakpoint (in category 'testing') -----
>> hasBreakpoint
>> + 	^ self class environment
>> + 		at: #BreakpointManager
>> + 		ifPresent: [:bpm | bpm methodHasBreakpoint: self]
>> + 		ifAbsent: [false]!
>> - 	^false!




More information about the Squeak-dev mailing list