After a first glimpse, I noted these:

1) GenericGFPoly evaluateAt: does not set the result in the loop...
2) why using an OrderedCollection for the coefficients ? an Array is faster.
   same for exp and log tables of GenericGF
3) GenericGF>>multiply:scalar: you changed <= size into < size but
shouldn't...

2015-12-15 12:30 GMT+01:00 Robert Withers <robert.w.withers at gmail.com>:

> Hi all, sticking with the distribution for discussing Crypto in the base,
> I am currently trying to stabilize a port of Reed-Solomon such that FEC can
> be added to SecureSession. I am doing this work in SecureSession. I just
> posted an update of the GenericGF class, with the Java implementation
> attached here.
>
> I need this critical code reviewed and tested. You need Cryptography and
> SecureSession to be included in the catalog. If you can help me with the
> former, I could help with the latter, if that suits you. Please let me know!
>
> Please load Cryptography(-Pharo) and SecureSession.23 for review.
>
> "ported & refactored GenericGF from the java code. This includes
> reindexing from 0 to 1. Having no tests, hopefully someone can give a
> review of this specific class. Where some tests to be developed at this
> scope, that would be stellar."
>
>
> I appreciate.
> --
> . .. .. ^,^ best, robert
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20151220/7ef08e1e/attachment.htm