[squeak-dev] Re: The Trunk: CollectionsTests-mt.227.mcz
Tobias Pape
Das.Linux at gmx.de
Thu Jan 15 12:26:49 UTC 2015
On 15.01.2015, at 12:11, Frank Shearar <frank.shearar at gmail.com> wrote:
> On 15 January 2015 at 11:05, Tobias Pape <Das.Linux at gmx.de> wrote:
>>
>> On 15.01.2015, at 10:59, Frank Shearar <frank.shearar at gmail.com> wrote:
>>
>>> They should, but if you're running the tests in some headless fashion
>>> - like in CI - those error messages let you zero in on problems much
>>> faster than just seeing "this test failed".
>>>
>>> I don't doubt that many tests would benefit from such a conversion: I
>>> just haven't done such a thing because of a lack of time, so I try get
>>> people to rewrite their new tests as they go in :)
>>
>> If we batch-convert, can we please also change
>>
>> self assert: expected equals: actual
>>
>> to
>>
>> self assert: actual equals: given
>>
>> ? This is IMHO more readable.
>> If this is a naming problem, what about
>>
>> self expect: actual toBe: given
>
> I'd rather take the latter option then. #assert:equals: does take the
> expected value first, and swapping the values reads better but then
> gives a deeply misleading message... and adjusting the message means
> there's a huge disconnect between our SUnit and the standard
> cross-platform SUnit.
yeah, you're right.
But using something like #expect:toBe: is then not portable either :(
Guess we'll stick with it until there's a new Framework ;)
Best
-Tobias
More information about the Squeak-dev
mailing list
|