[squeak-dev] The Trunk: System-nice.777.mcz

commits at source.squeak.org commits at source.squeak.org
Wed Nov 11 15:07:51 UTC 2015


Nicolas Cellier uploaded a new version of System to project The Trunk:
http://source.squeak.org/trunk/System-nice.777.mcz

==================== Summary ====================

Name: System-nice.777
Author: nice
Time: 11 November 2015, 4:07:14.754 pm
UUID: 86751135-3a70-41f9-aad1-e9de96bf1c70
Ancestors: System-nice.776

Let ImageSegment tests pass on Spur by fixing the erroneous endianness check.

Details:

In spur, primitive 98 which load an ImageSegment does become: the WordArrayForSegment segment into an Array. So all information about endianness is lost at this stage.

I don't know if the primitive will handle all kind of endianness, but it will eventually fail if it can't, and we won't get down to here, so the very best thing is to assume that endianness problems are already solved.

=============== Diff against System-nice.776 ===============

Item was changed:
  ----- Method: ImageSegment>>endianness (in category 'fileIn/Out') -----
  endianness
  	"Return which endian kind the incoming segment came from"
  
+ 	(segment isKindOf: WordArray)
+ 		ifFalse:
+ 			["Hope that primitive 98 did the right thing - anyway, we lost information about endianness, so the pretend we share image endianness."
+ 			^Smalltalk endianness].
  	^ (segment first bitShift: -24) asCharacter == $d ifTrue: [#big] ifFalse: [#little]!



More information about the Squeak-dev mailing list