[squeak-dev] The Trunk: SMLoader-cmm.85.mcz

karl ramberg karlramberg at gmail.com
Wed Sep 16 13:55:36 UTC 2015


Maybe it would be nice if the filters where off when opening the SqueakMap
browser. With filters on it seems to be empty and not functioning.

There is always warnings about package not being compatible when you try to
load them anyway.

Karl

On Tue, Sep 15, 2015 at 10:04 PM, Chris Muller <asqueaker at gmail.com> wrote:

> After review and some thought, it has become clear to me that Dave's
> change is incorrect.  Please take a look at the SqueakMap filters and
> consider them from the context of the use-cases -- what users need to
> do with SqueakMap, and NOT from the context of a database that needs
> to produce generalized "query results" <---- because it doesn't.
>
> "Published" are the ones which have software to install, while
> "Auto-installable" shows only packages that are installable from the
> "Install" menu selection within the image.  These two filters are
> useful together in a restricting fashion, not an inflating one, so
> that newbies can see what's ready to go.
>
> It was then that I also realized that Hannes' combination was not a
> use-case either.  The use-cases we have are:  1) user wants to install
> software or, 2) user wants to see what they have already installed.
> Seeing a cumulative list of both installed and uninstalled satisfies
> neither use-case.
>
> Nevertheless you may once again "Clear all filters" (which was broken
> by Dave's commit) if you want to see everything.
>
> I still say SqueakMap catalog can and needs improvement, but we need
> to really consider our changes because its clear that Göran put a lot
> of thought into the usage of SqueakMap and its role in the community;
> so I think we can afford to be a bit more skeptical before thinking
> something like that was a bug in the first place and for nine years
> running..
>
>
> On Tue, Sep 15, 2015 at 2:58 PM,  <commits at source.squeak.org> wrote:
> > Chris Muller uploaded a new version of SMLoader to project The Trunk:
> > http://source.squeak.org/trunk/SMLoader-cmm.85.mcz
> >
> > ==================== Summary ====================
> >
> > Name: SMLoader-cmm.85
> > Author: cmm
> > Time: 15 September 2015, 2:58:07.033 pm
> > UUID: 21a75b8d-4a1b-49c8-8f82-fbbd74fae96b
> > Ancestors: SMLoader-dtl.84
> >
> > Revert dtl.84, because it broke the Catalog filters.
> >
> > =============== Diff against SMLoader-dtl.84 ===============
> >
> > Item was changed:
> >   ----- Method: SMLoaderPlus>>packageListCalculated (in category
> 'lists') -----
> >   packageListCalculated
> >         "Return a list of the SMPackages that should be visible
> >         by applying all the filters. Also filter based on the currently
> >         selected category - if any."
> >         ^ self packages select: [:p |
> > +               filters allSatisfy: [:currFilter |
> > -               filters anySatisfy: [:currFilter |
> >                         currFilter isSymbol
> >                                 ifTrue: [(self perform: currFilter)
> value: p]
> >                                 ifFalse: [self package: p
> filteredByCategory: (map object: currFilter)]]]!
> >
> >
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20150916/fd8ae83f/attachment.htm


More information about the Squeak-dev mailing list