[squeak-dev] The Trunk: System-mt.893.mcz

commits at source.squeak.org commits at source.squeak.org
Tue Aug 16 08:35:36 UTC 2016


Marcel Taeumel uploaded a new version of System to project The Trunk:
http://source.squeak.org/trunk/System-mt.893.mcz

==================== Summary ====================

Name: System-mt.893
Author: mt
Time: 16 August 2016, 10:34:46.612039 am
UUID: 064d9a41-2264-4f43-aeec-03e5129b9b70
Ancestors: System-mt.892

Appendix to Morphic-mt.1283

=============== Diff against System-mt.892 ===============

Item was changed:
  ----- Method: ImageSegment>>copySmartRootsExport: (in category 'read/write segment') -----
  copySmartRootsExport: rootArray 
  	"Use SmartRefStream to find the object.  Make them all roots.  Create the segment in memory.  Project should be in first five objects in rootArray."
  	| newRoots list segSize symbolHolder replacements naughtyBlocks allClasses sizeHint proj dummy |
  
  	"self halt."
  	symbolHolder := Symbol allSymbols.	"Hold onto Symbols with strong pointers, 
  		so they will be in outPointers"
  
  	dummy := ReferenceStream on: (DummyStream on: nil).
  		"Write to a fake Stream, not a file"
  	"Collect all objects"
  	dummy insideASegment: true.	"So Uniclasses will be traced"
  	dummy rootObject: rootArray.	"inform him about the root"
  	dummy nextPut: rootArray.
  	(proj :=dummy project) ifNotNil: [self dependentsSave: dummy].
  	allClasses := SmartRefStream new uniClassInstVarsRefs: dummy.
  		"catalog the extra objects in UniClass inst vars.  Put into dummy"
  	allClasses do: [:cls | 
  		dummy references at: cls class put: false.	"put Player5 class in roots"
  		dummy blockers removeKey: cls class ifAbsent: []].
  	"refs := dummy references."
  	arrayOfRoots := self smartFillRoots: dummy.	"guaranteed none repeat"
  	self savePlayerReferences: dummy references.	"for shared References table"
  	replacements := dummy blockers.
  	dummy project "recompute it" ifNil: [self error: 'lost the project!!'].
  	dummy project class == DiskProxy ifTrue: [self error: 'saving the wrong project'].
  	dummy := nil.	"force GC?"
  	naughtyBlocks := arrayOfRoots select: [ :each |
  		(each isKindOf: ContextPart) and: [each hasInstVarRef]
  	].
  
  	"since the caller switched ActiveWorld, put the real one back temporarily"
  	naughtyBlocks isEmpty ifFalse: [
+ 		World becomeActiveDuring: [World firstHand becomeActiveDuring: [ | goodToGo |
- 		World becomeActiveDuring: [ | goodToGo |
  			goodToGo := (UIManager default
  				chooseFrom: #('keep going' 'stop and take a look')
  				title:
  'Some block(s) which reference instance variables 
  are included in this segment. These may fail when
  the segment is loaded if the class has been reshaped.
  What would you like to do?') = 1.
  			goodToGo ifFalse: [
  				naughtyBlocks inspect.
  				self error: 'Here are the bad blocks'].
+ 		]].
- 		].
  	].
  	"Creation of the segment happens here"
  
  	"try using one-quarter of memory min: four megs to publish (will get bumped later)"
  	sizeHint := (Smalltalk garbageCollect // 4 // 4) min: 1024*1024.
  	self copyFromRoots: arrayOfRoots sizeHint: sizeHint areUnique: true.
  	segSize := segment size.
  	[(newRoots := self rootsIncludingBlockMethods) == nil] whileFalse: [
  		arrayOfRoots := newRoots.
  		self copyFromRoots: arrayOfRoots sizeHint: segSize areUnique: true].
  		"with methods pointed at from outside"
  	[(newRoots := self rootsIncludingBlocks) == nil] whileFalse: [
  		arrayOfRoots := newRoots.
  		self copyFromRoots: arrayOfRoots sizeHint: segSize areUnique: true].
  		"with methods, blocks from outPointers"
  	list := self compactClassesArray.
  	outPointers := outPointers, ((list select: [:cls | cls ~~ nil]), (Array with: 1717 with: list)).
  	1 to: outPointers size do: [:ii | 
  		(outPointers at: ii) isBlock ifTrue: [outPointers at: ii put: nil].
  		(outPointers at: ii) class == MethodContext ifTrue: [outPointers at: ii put: nil].
  		"substitute new object in outPointers"
  		(replacements includesKey: (outPointers at: ii)) ifTrue: [
  			outPointers at: ii put: (replacements at: (outPointers at: ii))]].
  	proj ifNotNil: [self dependentsCancel: proj].
  	symbolHolder.!



More information about the Squeak-dev mailing list