[squeak-dev] The Trunk: Tools-eem.738.mcz

Chris Muller asqueaker at gmail.com
Sat Dec 24 22:24:19 UTC 2016


Hi Eliot, it appears that the MessageTrace is broken, which depends on
the elements being Strings.

Would you please fix it?


On Tue, Dec 20, 2016 at 4:15 PM,  <commits at source.squeak.org> wrote:
> Eliot Miranda uploaded a new version of Tools to project The Trunk:
> http://source.squeak.org/trunk/Tools-eem.738.mcz
>
> ==================== Summary ====================
>
> Name: Tools-eem.738
> Author: eem
> Time: 20 December 2016, 2:15:33.753612 pm
> UUID: 71a932b5-137d-49ba-8db9-9bb8e074b37e
> Ancestors: Tools-cmm.737
>
> Fix regression in RecentMessages due to Tools-eem.736.  Use MethodReference comparison instead of funky string comparison.
>
> =============== Diff against Tools-cmm.737 ===============
>
> Item was changed:
>   ----- Method: RecentMessageSet>>updateListsAndCodeIn: (in category 'update') -----
>   updateListsAndCodeIn: aWindow
> +       self canDiscardEdits ifFalse: [^self].
> +       RecentMessages default isEmpty ifTrue: [^self].
> +       (messageList isEmpty
> +        or: [RecentMessages default mostRecent = messageList first])
> +               ifTrue: [self updateCodePaneIfNeeded]
> +               ifFalse: [self reformulateList]!
> -       | recentFromUtilities |
> -       self canDiscardEdits ifFalse: [ ^ self ].
> -       RecentMessages default isEmpty ifTrue: [ ^ self ].
> -       recentFromUtilities := RecentMessages default mostRecent asString , ' '.
> -       (messageList isEmpty or: [ messageList first asStringOrText asString beginsWith: recentFromUtilities ])
> -               ifTrue: [ self updateCodePaneIfNeeded ]
> -               ifFalse: [ self reformulateList ]!
>
>


More information about the Squeak-dev mailing list