[squeak-dev] Re: Double-click gone missing?

tim Rowledge tim at rowledge.org
Tue Jan 12 18:17:57 UTC 2016


> On 12-01-2016, at 4:22 AM, marcel.taeumel <Marcel.Taeumel at hpi.de> wrote:
> 
> So it has been broken some time ago? There is just no double-click in the
> default tools? :) 

It’s broken by Eliot’s recent changes to the millisecond time stuff. The vm still passes events in with a 32 bit timestamp based on ioMSecs() but the various ‘faked’ events we have to use such as MouseEvent>asMouseMove use Time>millisecondClockValue. Which *used* to be based on ioMSecs() as well but is no longer. Thus any d-clicking will generally have problems because the core MouseClickState code must inevitably get confused by the resultant attempts to compare ioMSecs() values in the few-million range with primitive 241 values in the range umpty-gazillion.

The obvious nice way to deal with this is to upgrade the vm but that would screw all previous images and so on. Bad idea. Another option would be to add a method to one or other event related class to keep using the old prim for a millisecond value and update the user methods - ok for future images, mildly annoying but livable (maybe) for older ones. Or maybe it would be manageable to keep the millisecondsClockValue (either in the prim code or by in-image offset) working off the same base as the ioMSecs() code.

tim
--
tim Rowledge; tim at rowledge.org; http://www.rowledge.org/tim
Strange OpCodes: FSRA: Forms Skip and Run-Away




More information about the Squeak-dev mailing list