[squeak-dev] Re: swapMouseButtons broken in trunk
Chris Muller
asqueaker at gmail.com
Tue Mar 8 03:32:47 UTC 2016
May we please evaluate that from Inbox for a couple of weeks before
putting that into trunk?
We've added a new language feature being used for almost nothing but
Preferences, now we want to loosen the definition of Smalltalk
"senders" for them too?
I admit, your idea sounds interesting -- I, myself, pretty much only
instantiate Symbols which are also method selectors.
However, I think when we feel the need to change our tools
for something that should be dead simple, maybe its the design trying to
speak to us. Maybe its a good time to ask, "why are we
doing this? is there a simpler way?"
What I still don't understand is why we can't see the Preference's
'changeSelector' getting set to the value, #swapMouseButtonsChanged
anywhere? Should't the initial instantiation of the Preference object
require that as a parameter, and so then it should show up in senders,
and it would make sense how it worked..?? :(
On Mon, Mar 7, 2016 at 5:13 PM, marcel.taeumel <Marcel.Taeumel at hpi.de> wrote:
> It's actuallly really simple:
>
> term := #swapMouseButtonsChanged.
> senders := OrderedCollection new.
>
> SystemNavigation default allObjectsDo: [:ea |
> 1 to: ea class instSize do: [:i | |val|
> val := ea instVarAt: i.
> val isSymbol ifTrue: [
> val = term ifTrue: [senders add: ea]]]].
>
> senders explore.
>
> On my laptop, it benches to '11.6 per second. 85.9 milliseconds per run.'
>
> Should we add this to trunk? We could filter out method additions or method
> references to produce cleaner results. The "Senders" shortcut might just
> spawn an additional explorer with the resulting objects. Fairly easy.
>
> Best,
> Marcel
>
>
>
> --
> View this message in context: http://forum.world.st/swapMouseButtons-broken-in-trunk-tp4881884p4883109.html
> Sent from the Squeak - Dev mailing list archive at Nabble.com.
>
More information about the Squeak-dev
mailing list
|