[squeak-dev] Re: Fix for MergeBrowser

marcel.taeumel Marcel.Taeumel at hpi.de
Fri May 27 14:26:54 UTC 2016

Hi Karl,

after a quick look in the DNU I always get when "browse origin" of a method
change, I see that MCWorkingCopyBrowser class >> #mcModelFor: seems to be
not prepared to process an mc definition. Yes, MCDefinition does implement
#mcModel but the code in #mcModelFor: suggests that the author expected
classes or method references only. :-) So, the call in MCOperationsBrowser
>> #browseSelectorOrigin seems to misuse #mcModelFor: at the moment.

Anyway, I wonder why MCWorkingCopyBrowser class >> #mcModelFor: does exist
at all because it  bypasses the idea of polymorphism, which actually is
employed in #mcModel being implemented in Class, MethodReference,
MCHttpRepository, and MCRepository.

My suggestion for anybody who is willing to fix this is to move the code
from #mcModelFor: into those implementors of #mcModel, who need it.
Otherwise, it seems *really* difficult to understand this additional
dispatch -- and when to use it -- in the future for other developers.


View this message in context: http://forum.world.st/Fix-for-MergeBrowser-tp4897113p4897853.html
Sent from the Squeak - Dev mailing list archive at Nabble.com.

More information about the Squeak-dev mailing list