[squeak-dev] The Inbox: WebClient-Core-fn.105.mcz

commits at source.squeak.org commits at source.squeak.org
Thu Apr 27 16:32:56 UTC 2017


A new version of WebClient-Core was added to project The Inbox:
http://source.squeak.org/inbox/WebClient-Core-fn.105.mcz

==================== Summary ====================

Name: WebClient-Core-fn.105
Author: fn
Time: 27 April 2017, 6:32:47.94973 pm
UUID: 9d163339-62e5-4248-b3c4-773616160ea0
Ancestors: WebClient-Core-jr.104

Disable certificate validation on all platforms for the time being. It turns out, this does not only probably work on macOS, but also on Windows and Linux. The WebClient seems to have problems with some certificates used for popular domains, e.g. google.com and github.com. The Zinc library does not perform the validation as well at the moment.

=============== Diff against WebClient-Core-jr.104 ===============

Item was changed:
  ----- Method: WebClient>>sslConnect (in category 'initialize') -----
  sslConnect
  	"Do the SSL handshake"
  	"Connect the client to a web server"
  
  	| sqSSL |
  	proxyServer ifNotNil:[ | resp |
  		"If we have a proxy server, do the proxy connect"
  		resp := self proxyConnect.
  		resp isSuccess ifFalse:[^resp].
  	].
  
  	sqSSL := Smalltalk at: #SqueakSSL ifAbsent:[self error: 'SqueakSSL is missing'].
  	"Convert the stream to a secure stream"
  	stream := sqSSL secureSocketStream on: stream socket.
  	stream timeout: timeout.
  	self sslConnect: stream to: lastServer.
+ 
+ 	"Normally, we would verify the cert now, but this does not work properly"
+ 	"stream verifyCert: self serverName."
+ 
- 	"And cert verification
- 	(unless on OSX, where this does not work yet)"
- 	WebUtils platformName = 'Mac OS'
- 		ifFalse: [stream verifyCert: self serverName].
  	^ nil"indicating success"
  !



More information about the Squeak-dev mailing list