[squeak-dev] FileChooserDialog usage?

David T. Lewis lewis at mail.msen.com
Fri Dec 22 04:19:48 UTC 2017


On Thu, Dec 21, 2017 at 06:08:03PM -0500, David T. Lewis wrote:
> On Thu, Dec 21, 2017 at 02:13:10PM -0800, tim Rowledge wrote:
> > With luck the updates to the file dialog stuff are now published properly. In order to try out the new dialogs when hooked up, take a look at http://wiki.squeak.org/squeak/2758 and file in the attached changes.
> >
> 
> I filed in FileDialogs-StartUsage.cs from the wiki page and took a quick look
> at it. This makes a lot of sense now that I see it in use. There are quite a
> few places in the image where these dialogs happen, and using the new ones
> consistently seems like a very good improvement.
> 
> I do need to whine again about the class comment for FileChooserDialog, as it
> provides a non-working example, so this still needs an update. It might help
> also to just put examples into the method comments for #openOnSuffixList:label:
> and #openOnPattern:label: to clarify the difference.
> 
> Overall, I like it and +1 for using these new dialogs in the image.
> 
> Dave
>  

I tried playing around with the instance creation methods and comments,
and put the updates in the inbox as Tools-dtl.782.

Tim,

I don't know if you like the style for constructors, but the method and
class comments may be of some use.

Dave
 


More information about the Squeak-dev mailing list