[squeak-dev] The Inbox: Monticello-mva.662.mcz
Chris Muller
asqueaker at gmail.com
Thu Feb 9 22:52:36 UTC 2017
I was excited to test this, it is something that's bugged me for some time.
Hm, it seems like its a *little* better, but still not really able to
filter the repository list.. It still wants to download a new mcz on
every keystroke.
I was thinking that the filtering feature, maybe for this pane only
(based on some new boolean switch in the Model), could wait a
half-second before initiating the filter. Every keystroke would reset
the half-second timer..
On Thu, Feb 9, 2017 at 3:01 PM, <commits at source.squeak.org> wrote:
> A new version of Monticello was added to project The Inbox:
> http://source.squeak.org/inbox/Monticello-mva.662.mcz
>
> ==================== Summary ====================
>
> Name: Monticello-mva.662
> Author: mva
> Time: 9 February 2017, 9:32:09.809941 pm
> UUID: a5886414-f70f-9a42-82aa-99bc3158ef95
> Ancestors: Monticello-mva.661
>
> fix filtering for Repository browser's versionList
>
> =============== Diff against Monticello-mva.661 ===============
>
> Item was changed:
> MCVersionInspector subclass: #MCRepositoryInspector
> + instanceVariableNames: 'repository packageNames versionNames selectedPackage selectedVersion order versionInfo loaded newer inherited versionList versionSelection'
> - instanceVariableNames: 'repository packageNames versionNames selectedPackage selectedVersion order versionInfo loaded newer inherited'
> classVariableNames: 'BrowseBranchedVersionsSeparately Order'
> poolDictionaries: ''
> category: 'Monticello-UI'!
>
> Item was changed:
> ----- Method: MCRepositoryInspector>>order: (in category 'morphic ui') -----
> order: anInteger
> self class order: (order := anInteger).
> + self versionList: nil.
> self changed: #versionList.!
>
> Item was changed:
> ----- Method: MCRepositoryInspector>>packageSelection: (in category 'morphic ui') -----
> packageSelection: aNumber
> selectedPackage := (aNumber between: 1 and: self packageList size)
> ifTrue: [ (self packageList at: aNumber) asString ].
> self versionSelection: 0.
> versionNames := nil.
> + self versionList: nil.
> self changed: #packageSelection; changed: #versionList!
>
> Item was changed:
> ----- Method: MCRepositoryInspector>>refresh (in category 'actions') -----
> refresh
> packageNames := versionNames := newer := nil.
> repository refresh.
> + self versionList: nil.
> self
> changed: #packageList ;
> changed: #versionList.!
>
> Item was changed:
> ----- Method: MCRepositoryInspector>>versionList (in category 'morphic ui') -----
> versionList
> | result |
> + versionList ifNotNil: [ ^ versionList ].
> +
> result := selectedPackage
> ifNil: [ self versionNamesForNoPackageSelection ]
> ifNotNil: [ self versionNamesForSelectedPackage ].
> (self orderSpecs at: order) value ifNotNil:
> [ : sortBlock | result sort:
> [ : a : b | sortBlock
> value: a
> value: b ] ].
> + ^ versionList := result collect:
> - ^ result collect:
> [ : each | self versionHighlight: each ]!
>
> Item was added:
> + ----- Method: MCRepositoryInspector>>versionList: (in category 'morphic ui') -----
> + versionList: aValue
> + versionList := aValue!
>
> Item was changed:
> ----- Method: MCRepositoryInspector>>versionSelection (in category 'morphic ui') -----
> versionSelection
> + ^ versionSelection ifNil: [ 0 ]!
> - ^self versionList indexOf: selectedVersion!
>
> Item was changed:
> ----- Method: MCRepositoryInspector>>versionSelection: (in category 'morphic ui') -----
> versionSelection: aNumber
> + versionSelection := aNumber.
> selectedVersion := version := nil.
> aNumber isZero ifFalse: [ selectedVersion := (self versionList at: aNumber) asString ].
> self
> changed: #versionSelection ;
> changed: #summary ;
> changed: #hasVersion!
>
>
More information about the Squeak-dev
mailing list
|