[squeak-dev] Getting TestRunner (an others) in the Flaps registry [Was: The Trunk: SUnitGUI-eem.68.mcz]
eliot.miranda at gmail.com
Thu Jun 1 21:28:29 UTC 2017
Hi All, but especially release builders,
there may be an issue with the Flaops registry. The default
initialization is Flaps class>>#initializeFlapsQuads. But there are
additional class initializers that add to the Flaps registry, e.g.
TestRunner class>>registerInToolsFlap. If we unload flaps and then reload
it we will lose all the extra ones, such as TestRunner's. So for release
we should run all implementors of registerInToolsFlap
or registerInFlapsRegistry (or rather the relevant senders of
registerQuad:forFlapNamed:) to ensure all the classes that want to be in
the Flaps registry are there.
Note that if instead of a Flaps registry there was a class-side "I should
be in the Flaps registry" pragma, then this kind of error wouldn't happen.
Either the pragmas would be collected every time the flaps registry was
opened, or the Flaps registry would be updated whenever a method with the
pragma was added or removed.
On Thu, Jun 1, 2017 at 2:20 PM, <commits at source.squeak.org> wrote:
> Eliot Miranda uploaded a new version of SUnitGUI to project The Trunk:
> ==================== Summary ====================
> Name: SUnitGUI-eem.68
> Author: eem
> Time: 1 June 2017, 2:20:29.979374 pm
> UUID: 47ec06e5-6ff4-4475-9034-b298e6f98544
> Ancestors: SUnitGUI-ul.67
> If Flaps is present (and not loading for the first time) run the
> initialize method to make sure TestRunner is in the Flaps Tools registry.
> =============== Diff against SUnitGUI-ul.67 ===============
> Item was added:
> + (PackageInfo named: 'SUnitGUI') preamble: '"below, add code to be run
> before the loading of this package"
> + "If Flaps is present (and not loading for the first time) run the
> initialize method to make sure TestRunner is in the Flaps Tools registry."
> + (Smalltalk classNamed: #TestRunner) ifNotNil:
> + [:trc|
> + trc environment at: #Flaps ifPresent: [ :fc | trc initialize]]'!
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Squeak-dev