[squeak-dev] The Trunk: ST80Tests-dtl.5.mcz

H. Hirzel hannes.hirzel at gmail.com
Tue Nov 14 04:06:14 UTC 2017


Minor issue

On Tue, 14 Nov 2017 02:26:56 0000, commits at source.squeak.org
<commits at source.squeak.org> wrote:
> David T. Lewis uploaded a new version of ST80Tests to project The Trunk:
> http://source.squeak.org/trunk/ST80Tests-dtl.5.mcz
>
> ==================== Summary ====================
>
> Name: ST80Tests-dtl.5
> Author: dtl
> Time: 13 November 2017, 9:26:52.125552 pm
> UUID: 5bcbeaa0-c4f2-46c0-b555-d0312fff6f91
> Ancestors: ST80Tests-pre.4
>
> Remove unnecessary references to global world.
> Do not test nil World for project type, instead use Project current isMVC
>
> =============== Diff against ST80Tests-pre.4 ===============
>
> Item was changed:
>   ----- Method: MVCToolBuilderTests>>testWindowCloseAction (in category
> 'tests-not applicable') -----
>   testWindowCloseAction
>   	"This can only work if we're actually run in MVC"
Minor issue: the comment above is no longer necessary. Because now the
code is clear enough.
> + 	Project current isMVC ifTrue: [super testWindowCloseAction]!
> - 	World isNil ifTrue: [super testWindowCloseAction]!
I assume the comment was there because it is not obvious at all that
    World isNil
is the test for an MVC project.


>
>


More information about the Squeak-dev mailing list