[squeak-dev] The Trunk: ST80-tpr.230.mcz

commits at source.squeak.org commits at source.squeak.org
Sun Oct 22 01:05:53 UTC 2017


tim Rowledge uploaded a new version of ST80 to project The Trunk:
http://source.squeak.org/trunk/ST80-tpr.230.mcz

==================== Summary ====================

Name: ST80-tpr.230
Author: tpr
Time: 21 October 2017, 6:05:44.809305 pm
UUID: e41515c2-7a7a-4e5b-9945-e51908361389
Ancestors: ST80-nice.229

Small cleanups for the #browse... methods.
Note the thwy kinda-sorta parallel the TextEditor versions in a poor-relation manner that suggests we might be able to improve them.

=============== Diff against ST80-nice.229 ===============

Item was changed:
  ----- Method: ParagraphEditor>>browseClassFromIt (in category 'menu messages') -----
  browseClassFromIt
  	"Launch a browser for the class indicated by the current selection. 
  	If multiple classes matching the selection exist, let the user choose among them."
  	| aClass |
+ 
+ 	self lineSelectAndEmptyCheck: [^ self].
- 	self
- 		lineSelectAndEmptyCheck: [^ self].
  	aClass := UIManager default
  				classFromPattern: self selection string
  				withCaption: 'choose a class to browse...'.
+ 	aClass ifNil: [^ view flash].
+ 	self terminateAndInitializeAround: 
+ 			[self systemNavigation browseClass: aClass].!
- 	aClass
- 		ifNil: [^ view flash].
- 	self
- 		terminateAndInitializeAround: 
- 			[| aBrow |
- 			aBrow := SystemBrowser default new.
- 			aBrow setClass: aClass selector: nil.
- 			aBrow class
- 				openBrowserView: (aBrow openEditString: nil) label: 'System Browser'].!

Item was changed:
  ----- Method: ParagraphEditor>>browseIt (in category 'menu messages') -----
  browseIt
  	"Launch a browser for the current selection, if appropriate"
  
  	| aSymbol |
  	self flag: #yoCharCases.
  
  	Preferences alternativeBrowseIt ifTrue: [^ self browseClassFromIt].
  
  	self lineSelectAndEmptyCheck: [^ self].
  	(aSymbol := self selectedSymbol) isNil ifTrue: [^ view flash].
  
  	self terminateAndInitializeAround:
  		[aSymbol first isUppercase
+ 			ifTrue: [| anEntry |
+ 				anEntry := (Smalltalk at: aSymbol
+ 					ifAbsent: [ self systemNavigation browseAllImplementorsOf: aSymbol.
- 			ifTrue:
- 				[| anEntry |
- 				anEntry := (Smalltalk
- 					at: aSymbol
- 					ifAbsent:
- 						[ self systemNavigation browseAllImplementorsOf: aSymbol.
  						^ nil]).
  				anEntry isNil ifTrue: [^ view flash].
  				(anEntry isBehavior or: [ anEntry isTrait ])
  					ifFalse: [ anEntry := anEntry class ].
+ 				self systemNavigation browseClass: anEntry.
+ 			] ifFalse:[ self systemNavigation browseAllImplementorsOf: aSymbol]]!
- 				ToolSet browse: anEntry selector: nil.
- 		] ifFalse:[ self systemNavigation browseAllImplementorsOf: aSymbol]]!



More information about the Squeak-dev mailing list