[squeak-dev] The Inbox: WebClient-Core-monty.113.mcz

commits at source.squeak.org commits at source.squeak.org
Sun Oct 29 03:27:55 UTC 2017


A new version of WebClient-Core was added to project The Inbox:
http://source.squeak.org/inbox/WebClient-Core-monty.113.mcz

==================== Summary ====================

Name: WebClient-Core-monty.113
Author: monty
Time: 28 October 2017, 11:27:48.373217 pm
UUID: 919f26df-a1e0-4287-aa95-507bcaf6f670
Ancestors: WebClient-Core-topa.112

Moved the WebResponse send of #closeIfTransient in #content and the HEAD request and 204 (no content) handling from #getContent to a super-sending implementation of the lower-level #getContentWithProgress:, so both #content and #contentWithProgress: will have the same behavior.

=============== Diff against WebClient-Core-topa.112 ===============

Item was removed:
- ----- Method: WebResponse>>content (in category 'accessing') -----
- content
- 	"Reimplemented to close the socket if the request is transient"
- 
- 	content ifNil:[
- 		content := self getContent.
- 		self closeIfTransient.
- 	].
- 	^content!

Item was removed:
- ----- Method: WebResponse>>getContent (in category 'private') -----
- getContent
- 	"Do not read any content if this was a HEAD request or code is 204 (no content)"
- 	(request method = 'HEAD' or: [code = 204]) ifTrue:[^''].
- 	^super getContent!

Item was added:
+ ----- Method: WebResponse>>getContentWithProgress: (in category 'private') -----
+ getContentWithProgress: progressBlockOrNil
+ 	| result |
+ 
+ 	"Do not read any content if this was a HEAD request or code is 204 (no content)"
+ 	result :=
+ 		(request method = 'HEAD' or: [code = 204])
+ 			ifTrue: ['']
+ 			ifFalse: [super getContentWithProgress: progressBlockOrNil].
+ 	"Reimplemented to close the socket if the request is transient"
+ 	self closeIfTransient.
+ 	^ result.!



More information about the Squeak-dev mailing list