[squeak-dev] The Inbox: MorphicExtras-hjh.202.mcz

H. Hirzel hannes.hirzel at gmail.com
Sat Sep 16 12:01:07 UTC 2017


Regarding the note of Tim R.
http://lists.squeakfoundation.org/pipermail/squeak-dev/2017-September/195233.html

about #windowColor


The 'GraphicalDictionaryMenu'
(opened through 'Extras/Graphical Imports') menu

does not follow the new UserInterfaceTheme conventions. If you change
the theme, it is not changed in  the inspector for graphical imports
(pictures loaded into the image).

--Hannes


On 3/15/17, H. Hirzel <hannes.hirzel at gmail.com> wrote:
> Thanks for merging.
>
> In connection with checking out Tony's suggested change for the 'Dark
> solarized theme' I found out that in addition something like
>
>
>
> GraphicalDictionaryMenu  method
>
> windowColorToUse
>
> 	^ self userInterfaceTheme defaultWindowColor ifNil: [Color
> veryVeryLightGray]
>
>
> is necessary.
>
> However the 'GraphicalDictionaryMenu' (opened through
> 'Extras/Graphical Imports') menu does not follow the new
> UserInterfaceTheme conventions, so I'll do some more investigations
> before I submit another fix.
>
> It will include an updated comment as well.
>
> --Hannes
>
> On 3/15/17, David T. Lewis <lewis at mail.msen.com> wrote:
>> On Tue, Mar 14, 2017 at 09:42:17AM +0100, H. Hirzel wrote:
>>> Hello
>>>
>>> The fix which allows imported pictures to be displayed with the proper
>>> aspect ratio
>>>
>>> has been working fine so far since January 24th in my working image.
>>>
>>> The bug reported before in the previous mails seemingly was unrelated.
>>>
>>> In addition I just retested it in a most recent trunk version (see
>>> screen
>>> shot).
>>>
>>> Could somebody with commit rights please have a look at the fix and
>>> move it into trunk?
>>>
>>
>> Done, and merged.
>>
>> Thanks,
>> Dave
>>
>>
>>
>


More information about the Squeak-dev mailing list