[squeak-dev] The Trunk: Tests-mt.383.mcz

commits at source.squeak.org commits at source.squeak.org
Mon Sep 18 09:44:02 UTC 2017

Marcel Taeumel uploaded a new version of Tests to project The Trunk:

==================== Summary ====================

Name: Tests-mt.383
Author: mt
Time: 18 September 2017, 11:43:21.93578 am
UUID: a6f43f48-58a8-774e-8ad4-3b102f1fda9d
Ancestors: Tests-mt.382

Adds and fixes tests considering that current UI themes do not have to be registered such as in test code.

=============== Diff against Tests-mt.382 ===============

Item was changed:
  ----- Method: UserInterfaceThemeTest>>test27ScopeIntegrity (in category 'tests') -----
  	"If application code manages to use Object >> #userInterfaceTheme without invoking the DNU dispatch directly afterwards, the theme's scope might get inconsistent. Even though this should usually never happen, check for it to be sure."
  	| issues |
  	issues := OrderedCollection new.
  	UserInterfaceTheme allThemes do: [:uit |
  		(uit instVarNamed: #scope) isEmpty ifFalse: [issues add: uit]].
+ 	UserInterfaceTheme current in: [:uit |
+ 		(UserInterfaceTheme allThemes includes: uit)
+ 			ifFalse: [(uit instVarNamed: #scope) isEmpty ifFalse: [issues add: uit]]].
  	self assert: issues isEmpty description: 'Some user interface themes have an inconsistent scope state, which can interfere with GC.'.!

Item was added:
+ ----- Method: UserInterfaceThemeTest>>test28DanglingTheme (in category 'tests') -----
+ test28DanglingTheme
+ 	self
+ 		assert: (UserInterfaceTheme allThemes includes: UserInterfaceTheme current)
+ 		description: 'The current user interface theme is not registered.'.!

More information about the Squeak-dev mailing list