Thanks Dave! VersionNumberTest is very modest but your message made my day.
There were no compelling reason to write the test in 2009 but just to say
every contribution comes to be helpful at some point. We got to love Open
Source. :)

Ian

2017-09-21 20:56 GMT-04:00 David T. Lewis <lewis at mail.msen.com>:

> On Thu, Sep 21, 2017 at 01:53:45PM -0400, Ian Trudel wrote:
> > VersionNumber was particular from the ground up. It was not documented
> > until I wrote VersionNumberTest back in 2009.
> >
> > The fact that it was not supporting 0 was odd but the tests were written
> to
> > conform to what was already there.
> >
> > The idea was if someone wants to change VersionNumber, they could change
> > VersionNumberTest first and ensure an easy transition while retaining
> (some
> > or full) compatibility.
>
>
> Ian,
>
> Thank you for this. Writing VersionNumberTest was exactly the right thing
> to do in this case, and the current discussion shows why it was important
> for you to do it.
>
> I was just about to respond to this thread with something along the lines
> of "change it any way you want, but please be sure to document it with
> unit tests".
>
> And of course you also provided a meaningful class comment in
> VersionNumberTest
> that provides some background for this discossion, so thanks also for that.
>
> :-)
>
> Dave
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20170922/d41d63e4/attachment.html>