[squeak-dev] Missing Class Method in #MenuIcons

Chris Muller ma.chris.m at gmail.com
Wed Apr 25 23:58:04 UTC 2018


Your change is in trunk.

Thank you for the contribution.


On Wed, Apr 25, 2018 at 5:33 PM, John-Reed Maffeo <jrmaffeo at gmail.com>
wrote:

> I have no opinion, I just copied what was used in #ToolIcons. #HelpIcons
> currently uses #Dictionary. It makes sense that they would all used the
> same pattern. I have not made any contributions in quite a while and I am
> not up to speed with the community development model. I checked the wiki
> for info about the community development model, but I am not quite sure how
> to use it. I can access the Repository at http://source.squeak.org/inbox
> in Monticello Browser, but I am not sure what to do next (or even if I
> should).
>
> The attached change set updates the class method #icon in #ToolIcons and
> #MenuIcons to be consistent with the use of #Dictionary in #HelpIcons. All
> three should now be the same.
>
> My only test was to #do
>
> ToolIcons icons explore.
> MenuIcons icons explore.
> HelpIcons icons explore.
>
> in a Workspace. Results appeared to be correct.
>
>
> Cheers,
>
> jrm
>
> On Wed, Apr 25, 2018 at 1:58 PM, Chris Muller <asqueaker at gmail.com> wrote:
>
>> I think it's wrong for it to be an IdentityDictionary, even though the
>> keys are Symbols.  We should convert it to a plain Dictionary.
>>
>> On Tue, Apr 24, 2018 at 7:56 PM, John-Reed Maffeo <jrmaffeo at gmail.com>
>> wrote:
>> > The class method #icons is missing from #MenuIcons.
>> >
>> > I have attached my tested proposal for a replacement.
>> >
>> > - jrm
>> >
>> >
>> >
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20180425/189bfe6b/attachment.html>


More information about the Squeak-dev mailing list